From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1W0U-0007zU-Ek for qemu-devel@nongnu.org; Mon, 30 Jun 2014 03:28:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1W0O-0003PL-9s for qemu-devel@nongnu.org; Mon, 30 Jun 2014 03:28:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1W0O-0003Mz-18 for qemu-devel@nongnu.org; Mon, 30 Jun 2014 03:28:00 -0400 Message-ID: <1404113274.17465.1.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 30 Jun 2014 09:27:54 +0200 In-Reply-To: <1403516125-14568-1-git-send-email-peter.maydell@linaro.org> References: <1403516125-14568-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] ui/cocoa: Fix absolute positioning and other bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Andreas =?ISO-8859-1?Q?F=E4rber?= , qemu-devel@nongnu.org On Mo, 2014-06-23 at 10:35 +0100, Peter Maydell wrote: > This set of cocoa UI patches: > * fixes the completely broken handling of absolute positioning > (tablet-style) input devices > * fixes a bug where if the first surface created was the same 640x480 > as the initial window we'd never actually draw it > * implements support for the -show-cursor command line option > > The GTK and SDL UI frontends don't seem to be consistent about how they > handle mousegrab for absolute-position devices; I followed SDL on the > basis that it was the older and more established UI. (GTK doesn't > implement -show-cursor at all, incidentally.) Series looks sane to me, although I can't claim I fully understand patch #3, especially the macos x mouse handling internals involved there ... cheers, Gerd