From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1YkI-0008KW-LN
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:23:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1YkC-0000Wm-AJ
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:23:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1YkC-0000V5-33
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:23:28 -0400
Message-ID: <1404123796.24066.18.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 30 Jun 2014 12:23:16 +0200
In-Reply-To: <87fviviydy.fsf@blackfin.pond.sub.org>
References: <1403297751-10379-1-git-send-email-peter.maydell@linaro.org>
	<87fviviydy.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to
 parse/kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, patches@linaro.org, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>

  Hi,

> >  * The old qemu_chr_open_socket() has an
> >    "if (!is_waitconnect)
> >        qemu_set_nonblock(fd);
> >    which the QMP char-open codepath has never had. Does this matter?
> >    Which of the two code paths was correct?
> 
> Gerd?

IIRC the socket is put into non-blocking mode anyway by the qemu socket
helper functions.

cheers,
  Gerd