From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1Zuw-0006eh-Mu
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 07:38:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1Zup-00078c-6K
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 07:38:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X1Zuo-00078T-V1
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 07:38:31 -0400
Message-ID: <1404128306.24066.30.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 30 Jun 2014 13:38:26 +0200
In-Reply-To: <1403565068-15229-14-git-send-email-benh@kernel.crashing.org>
References: <1403565068-15229-1-git-send-email-benh@kernel.crashing.org>
	<1403565068-15229-14-git-send-email-benh@kernel.crashing.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 13/14] vga: Add endian control register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: qemu-devel@nongnu.org

  Hi,

> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
> index ae64321..894c6ab 100644
> --- a/hw/display/vga_int.h
> +++ b/hw/display/vga_int.h
> @@ -47,6 +47,8 @@
>  #define VBE_DISPI_INDEX_Y_OFFSET        0x9
>  #define VBE_DISPI_INDEX_NB              0xa /* size of vbe_regs[] */
>  #define VBE_DISPI_INDEX_VIDEO_MEMORY_64K 0xa /* read-only, not in vbe_regs */
> +#define VBE_DISPI_INDEX_EXTENDED_CAPS   0xb /* read-only, not in vbe_regs */
> +#define VBE_DISPI_INDEX_ENDIAN_CTRL     0xc /* not in vbe_regs */
>  
>  #define VBE_DISPI_ID0                   0xB0C0
>  #define VBE_DISPI_ID1                   0xB0C1
> @@ -55,13 +57,22 @@
>  #define VBE_DISPI_ID4                   0xB0C4
>  #define VBE_DISPI_ID5                   0xB0C5

I was more thinking to add ID6 to indicate the new interface revision
with the additional VBE_DISPI_INDEX_ENDIAN_CTRL register.

I'm a bit worried that there is no response from the bochs guys yet, I
don't want have two incompatible rev6 interfaces.  At least nobody seems
to have defined one so far, google finds nothing for "bochs dispi
0xB0C6".

cheers,
  Gerd