From: Sebastian Tanase <sebastian.tanase@openwide.fr>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, alex@alex.org.uk,
wenchaoqemu@gmail.com, quintela@redhat.com, mjt@tls.msk.ru,
mst@redhat.com, stefanha@redhat.com, armbru@redhat.com,
lcapitulino@redhat.com, michael@walle.cc, aliguori@amazon.com,
crobinso@redhat.com, pbonzini@redhat.com,
Sebastian Tanase <sebastian.tanase@openwide.fr>,
afaerber@suse.de, rth@twiddle.net
Subject: [Qemu-devel] [RFC PATCH V3 3/6] icount: Make icount_time_shift available everywhere
Date: Mon, 30 Jun 2014 15:59:06 +0200 [thread overview]
Message-ID: <1404136749-523-4-git-send-email-sebastian.tanase@openwide.fr> (raw)
In-Reply-To: <1404136749-523-1-git-send-email-sebastian.tanase@openwide.fr>
icount_time_shift is used for calculting the delay
qemu has to sleep in order to synchronise the
host and guest clocks. Therefore, we need it in
cpu-exec.c.
Signed-off-by: Sebastian Tanase <sebastian.tanase@openwide.fr>
Tested-by: Camille Bégué <camille.begue@openwide.fr>
---
cpus.c | 8 ++++++--
include/qemu-common.h | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 3fa8ce7..312c2ee 100644
--- a/cpus.c
+++ b/cpus.c
@@ -105,8 +105,12 @@ static bool all_cpu_threads_idle(void)
/* Compensate for varying guest execution speed. */
static int64_t qemu_icount_bias;
static int64_t vm_clock_warp_start;
-/* Conversion factor from emulated instructions to virtual clock ticks. */
-static int icount_time_shift;
+/* Conversion factor from emulated instructions to virtual clock ticks.
+ * icount_time_shift is defined as extern in include/qemu-common.h because
+ * it is used (in cpu-exec.c) for calculating the delay for sleeping
+ * qemu in order to align the host and virtual clocks.
+ */
+int icount_time_shift;
/* Arbitrarily pick 1MIPS as the minimum allowable speed. */
#define MAX_ICOUNT_SHIFT 10
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 860bb15..f568635 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -108,6 +108,7 @@ static inline char *realpath(const char *path, char *resolved_path)
/* icount */
void configure_icount(QemuOpts *opts, Error **errp);
extern int use_icount;
+extern int icount_time_shift;
extern int icount_align_option;
#include "qemu/osdep.h"
--
2.0.0.rc2
next prev parent reply other threads:[~2014-06-30 13:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 13:59 [Qemu-devel] [RFC PATCH V3 0/6] icount: Implement delay algorithm between guest and host clocks Sebastian Tanase
2014-06-30 13:59 ` [Qemu-devel] [RFC PATCH V3 1/6] icount: Add QemuOpts for icount Sebastian Tanase
2014-07-01 8:59 ` Frederic Konrad
2014-06-30 13:59 ` [Qemu-devel] [RFC PATCH V3 2/6] icount: Add align option to icount Sebastian Tanase
2014-06-30 16:33 ` Paolo Bonzini
2014-07-01 15:26 ` Sebastian Tanase
2014-06-30 13:59 ` Sebastian Tanase [this message]
2014-06-30 13:59 ` [Qemu-devel] [RFC PATCH V3 4/6] cpu_exec: Add sleeping algorithm Sebastian Tanase
2014-06-30 16:46 ` Paolo Bonzini
2014-07-01 15:44 ` Sebastian Tanase
2014-06-30 17:08 ` Paolo Bonzini
2014-06-30 13:59 ` [Qemu-devel] [RFC PATCH V3 5/6] cpu_exec: Print to console if the guest is late Sebastian Tanase
2014-06-30 17:11 ` Paolo Bonzini
2014-07-01 15:52 ` Sebastian Tanase
2014-06-30 13:59 ` [Qemu-devel] [RFC PATCH V3 6/6] monitor: Add drift info to 'info jit' Sebastian Tanase
2014-07-01 7:47 ` Frederic Konrad
2014-07-01 15:55 ` Sebastian Tanase
2014-06-30 17:16 ` [Qemu-devel] [RFC PATCH V3 0/6] icount: Implement delay algorithm between guest and host clocks Paolo Bonzini
2014-07-01 15:54 ` Sebastian Tanase
2014-07-04 15:36 ` Sebastian Tanase
2014-07-04 15:49 ` Paolo Bonzini
2014-07-04 16:05 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404136749-523-4-git-send-email-sebastian.tanase@openwide.fr \
--to=sebastian.tanase@openwide.fr \
--cc=afaerber@suse.de \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=crobinso@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=michael@walle.cc \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=wenchaoqemu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).