From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 2/5] sdhci: Fix misuse of qemu_free_irqs()
Date: Tue, 1 Jul 2014 05:08:10 +0200 [thread overview]
Message-ID: <1404184093-966-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1404184093-966-1-git-send-email-afaerber@suse.de>
It does a g_free() on the pointer, so don't pass a local &foo reference.
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-stable@nongnu.org
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index e2951e6..3e13d70 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1184,8 +1184,8 @@ static void sdhci_uninitfn(Object *obj)
timer_free(s->insert_timer);
timer_del(s->transfer_timer);
timer_free(s->transfer_timer);
- qemu_free_irqs(&s->eject_cb);
- qemu_free_irqs(&s->ro_cb);
+ qemu_free_irq(s->eject_cb);
+ qemu_free_irq(s->ro_cb);
if (s->fifo_buffer) {
g_free(s->fifo_buffer);
--
1.8.4.5
next prev parent reply other threads:[~2014-07-01 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 3:08 [Qemu-devel] [PULL 0/5] QOM devices patch queue 2014-07-01 Andreas Färber
2014-07-01 3:08 ` [Qemu-devel] [PULL 1/5] qom: Remove parent pointer when unparenting Andreas Färber
2014-07-01 3:08 ` Andreas Färber [this message]
2014-07-01 3:08 ` [Qemu-devel] [PULL 3/5] hw: Fix qemu_allocate_irqs() leaks Andreas Färber
2014-07-01 3:08 ` [Qemu-devel] [PULL 4/5] irq: Allocate IRQs individually Andreas Färber
2014-07-01 3:08 ` [Qemu-devel] [PULL 5/5] irq: Slim conversion of qemu_irq to QOM Andreas Färber
2014-07-01 10:55 ` [Qemu-devel] [PULL 0/5] QOM devices patch queue 2014-07-01 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404184093-966-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).