From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL for-2.1 07/24] virtio-blk: drop virtio_blk_set_conf()
Date: Tue, 1 Jul 2014 10:48:40 +0200 [thread overview]
Message-ID: <1404204537-5082-8-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1404204537-5082-1-git-send-email-stefanha@redhat.com>
This function is no longer used since parent objects now use child
aliases to set the VirtIOBlkConf directly.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/block/virtio-blk.c | 6 ------
include/hw/virtio/virtio-blk.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index e59ebc9..f1a667c 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -677,12 +677,6 @@ static const BlockDevOps virtio_block_ops = {
.resize_cb = virtio_blk_resize,
};
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk)
-{
- VirtIOBlock *s = VIRTIO_BLK(dev);
- memcpy(&(s->blk), blk, sizeof(struct VirtIOBlkConf));
-}
-
#ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
/* Disable dataplane thread during live migration since it does not
* update the dirty memory bitmap yet.
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 1d80bcc..52e5add 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -178,8 +178,6 @@ typedef struct VirtIOBlockReq {
DEFINE_PROP_BIT("config-wce", _state, _field.config_wce, 0, true), \
DEFINE_PROP_IOTHREAD("x-iothread", _state, _field.iothread)
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk);
-
int virtio_blk_handle_scsi_req(VirtIOBlock *blk,
VirtQueueElement *elem);
--
1.9.3
next prev parent reply other threads:[~2014-07-01 8:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:48 [Qemu-devel] [PULL for-2.1 00/24] Block patches Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 01/24] qom: add object_property_add_alias() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 02/24] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 03/24] dataplane: bail out on unsupported transport Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 04/24] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 05/24] qdev: add qdev_alias_all_properties() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 06/24] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-07-01 8:48 ` Stefan Hajnoczi [this message]
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 08/24] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 09/24] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 10/24] virtio-blk: replace x-iothread with iothread link property Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 11/24] qdev: drop iothread property type Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 12/24] virtio-blk: remove need for explicit x-data-plane=on option Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option Stefan Hajnoczi
2014-07-02 3:10 ` Eric Blake
2014-07-02 4:34 ` Chun Yan Liu
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 14/24] iotests: Simplify qemu-iotests-quick.sh Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 15/24] iotests: Add qemu tests to quick group Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 16/24] iotests: Add more " Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 17/24] block: make 'top' argument to block-commit optional Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 18/24] block: simplify bdrv_find_base() and bdrv_find_overlay() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 19/24] block/cow: Avoid use of uninitialized cow_bs in error path Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 20/24] qapi: Change back sector-count to sectors-count in quorum QAPI events Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change Stefan Hajnoczi
2014-07-01 22:09 ` Eric Blake
2014-07-02 13:53 ` Kevin Wolf
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 22/24] block: add helper function to determine if a BDS is in a chain Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 23/24] block: extend block-commit to accept a string for the backing file Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream Stefan Hajnoczi
2014-07-01 20:50 ` Eric Blake
2014-07-01 22:06 ` Eric Blake
2014-07-01 13:21 ` [Qemu-devel] [PULL for-2.1 00/24] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404204537-5082-8-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).