Re: [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2014-07-01 at 09:09 +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > -        if (depth == 32 || ((depth == 16 || depth == 15) && !byteswap)) {
> > +	if (depth == 32 || depth == 24 ||
> > +           ((depth == 16 || depth == 15) && !byteswap)) {
> 
> Doesn't apply.  

> depth == 15 isn't upstream. 

It's added by the previous patch, I just git send-email'ed the series
with the wrong starting point :-) I'll resend when I've addressed the
other comments.

If you want to see the whole lot (including my fix to one of your
patches) it's at https://github.com/ozbenh/qemu/commits/vga-work

>  Guess you have some more
> local changes?

>   Also the whitespace looks fishy (tabs vs. spaces?).
> Note that the qemu whitespace codestyle (spaces only) differs from linux
> kernel ...

Yes, I am aware of that, I might have accidentally left a tab slip in,
my emacs is still configured for Linux and I'm fixing them up "by hand"
but that's obviously sub-optimal, I'll look into fixing that.

Cheers,
Ben.

> cheers,
>   Gerd
>