From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1uPc-00084V-Mh for qemu-devel@nongnu.org; Tue, 01 Jul 2014 05:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1uPX-00049s-3P for qemu-devel@nongnu.org; Tue, 01 Jul 2014 05:31:40 -0400 Received: from gate.crashing.org ([63.228.1.57]:46933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1uPW-00049m-QP for qemu-devel@nongnu.org; Tue, 01 Jul 2014 05:31:35 -0400 Message-ID: <1404207089.29546.45.camel@pasglop> From: Benjamin Herrenschmidt Date: Tue, 01 Jul 2014 19:31:29 +1000 In-Reply-To: <1404198596.24066.50.camel@nilsson.home.kraxel.org> References: <1403565068-15229-1-git-send-email-benh@kernel.crashing.org> <1403565068-15229-2-git-send-email-benh@kernel.crashing.org> <1404198596.24066.50.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, 2014-07-01 at 09:09 +0200, Gerd Hoffmann wrote: > Hi, > > > - if (depth == 32 || ((depth == 16 || depth == 15) && !byteswap)) { > > + if (depth == 32 || depth == 24 || > > + ((depth == 16 || depth == 15) && !byteswap)) { > > Doesn't apply. > depth == 15 isn't upstream. It's added by the previous patch, I just git send-email'ed the series with the wrong starting point :-) I'll resend when I've addressed the other comments. If you want to see the whole lot (including my fix to one of your patches) it's at https://github.com/ozbenh/qemu/commits/vga-work > Guess you have some more > local changes? > Also the whitespace looks fishy (tabs vs. spaces?). > Note that the qemu whitespace codestyle (spaces only) differs from linux > kernel ... Yes, I am aware of that, I might have accidentally left a tab slip in, my emacs is still configured for Linux and I'm fixing them up "by hand" but that's obviously sub-optimal, I'll look into fixing that. Cheers, Ben. > cheers, > Gerd >