From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1yif-0002Qz-Gi for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:07:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1yiZ-0003HM-DG for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:07:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1yiZ-0003Gv-3M for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:07:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s61E7UgS027979 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 1 Jul 2014 10:07:30 -0400 From: Gerd Hoffmann Date: Tue, 1 Jul 2014 16:07:25 +0200 Message-Id: <1404223646-7899-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1404223646-7899-1-git-send-email-kraxel@redhat.com> References: <1404223646-7899-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 3/4] usb: initialize libusb_device to avoid crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jincheng Miao , Gerd Hoffmann From: Jincheng Miao If libusb_get_device_list() fails, the uninitialized local variable libusb_device would be passed to libusb_free_device_list(), that will cause a crash, like: (gdb) bt #0 0x00007fbbb4bafc10 in pthread_mutex_lock () from /lib64/libpthread.so.0 #1 0x00007fbbb233e653 in libusb_unref_device (dev=0x6275682d627375) at core.c:902 #2 0x00007fbbb233e739 in libusb_free_device_list (list=0x7fbbb6e8436e, unref_devices=) at core.c:653 #3 0x00007fbbb6cd80a4 in usb_host_auto_check (unused=unused@entry=0x0) at hw/usb/host-libusb.c:1446 #4 0x00007fbbb6cd8525 in usb_host_initfn (udev=0x7fbbbd3c5670) at hw/usb/host-libusb.c:912 #5 0x00007fbbb6cc123b in usb_device_init (dev=0x7fbbbd3c5670) at hw/usb/bus.c:106 ... So initialize libusb_device at the begin time. Signed-off-by: Jincheng Miao Reviewed-by: Gonglei Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 33b5b9f..c189147 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1522,7 +1522,7 @@ static void usb_host_auto_check(void *unused) { struct USBHostDevice *s; struct USBAutoFilter *f; - libusb_device **devs; + libusb_device **devs = NULL; struct libusb_device_descriptor ddesc; int unconnected = 0; int i, n; @@ -1623,7 +1623,7 @@ static void usb_host_auto_check(void *unused) void usb_host_info(Monitor *mon, const QDict *qdict) { - libusb_device **devs; + libusb_device **devs = NULL; struct libusb_device_descriptor ddesc; char port[16]; int i, n; -- 1.8.3.1