From: Ming Lei <ming.lei@canonical.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Ming Lei <ming.lei@canonical.com>,
Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v4 1/3] block: block: introduce APIs for submitting IO as
Date: Wed, 2 Jul 2014 20:18:46 +0800 [thread overview]
Message-ID: <1404303528-7115-2-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1404303528-7115-1-git-send-email-ming.lei@canonical.com>
a batch
This patch introduces three APIs so that following
patches can support queuing I/O requests and submitting them
as a batch for improving I/O performance.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
block.c | 31 +++++++++++++++++++++++++++++++
include/block/block.h | 4 ++++
include/block/block_int.h | 5 +++++
3 files changed, 40 insertions(+)
diff --git a/block.c b/block.c
index 217f523..4f64c38 100644
--- a/block.c
+++ b/block.c
@@ -1910,6 +1910,7 @@ void bdrv_drain_all(void)
bool bs_busy;
aio_context_acquire(aio_context);
+ bdrv_flush_io_queue(bs);
bdrv_start_throttled_reqs(bs);
bs_busy = bdrv_requests_pending(bs);
bs_busy |= aio_poll(aio_context, bs_busy);
@@ -5774,3 +5775,33 @@ bool bdrv_is_first_non_filter(BlockDriverState *candidate)
return false;
}
+
+void bdrv_io_plug(BlockDriverState *bs)
+{
+ BlockDriver *drv = bs->drv;
+ if (drv && drv->bdrv_io_plug) {
+ drv->bdrv_io_plug(bs);
+ } else if (bs->file) {
+ bdrv_io_plug(bs->file);
+ }
+}
+
+void bdrv_io_unplug(BlockDriverState *bs)
+{
+ BlockDriver *drv = bs->drv;
+ if (drv && drv->bdrv_io_unplug) {
+ drv->bdrv_io_unplug(bs);
+ } else if (bs->file) {
+ bdrv_io_unplug(bs->file);
+ }
+}
+
+void bdrv_flush_io_queue(BlockDriverState *bs)
+{
+ BlockDriver *drv = bs->drv;
+ if (drv && drv->bdrv_flush_io_queue) {
+ drv->bdrv_flush_io_queue(bs);
+ } else if (bs->file) {
+ bdrv_flush_io_queue(bs->file);
+ }
+}
diff --git a/include/block/block.h b/include/block/block.h
index d0baf4f..7a8b990 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -578,4 +578,8 @@ AioContext *bdrv_get_aio_context(BlockDriverState *bs);
*/
void bdrv_set_aio_context(BlockDriverState *bs, AioContext *new_context);
+void bdrv_io_plug(BlockDriverState *bs);
+void bdrv_io_unplug(BlockDriverState *bs);
+void bdrv_flush_io_queue(BlockDriverState *bs);
+
#endif
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 715c761..c5c4adc 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -257,6 +257,11 @@ struct BlockDriver {
void (*bdrv_attach_aio_context)(BlockDriverState *bs,
AioContext *new_context);
+ /* io queue for linux-aio */
+ void (*bdrv_io_plug)(BlockDriverState *bs);
+ void (*bdrv_io_unplug)(BlockDriverState *bs);
+ void (*bdrv_flush_io_queue)(BlockDriverState *bs);
+
QLIST_ENTRY(BlockDriver) list;
};
--
1.7.9.5
next prev parent reply other threads:[~2014-07-02 12:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 12:18 [Qemu-devel] [PATCH v4 0/3] linux-aio: introduce submit I/O as a batch Ming Lei
2014-07-02 12:18 ` Ming Lei [this message]
2014-07-02 12:46 ` [Qemu-devel] [PATCH v4 1/3] block: block: introduce APIs for submitting IO as Eric Blake
2014-07-03 9:40 ` Kevin Wolf
2014-07-02 12:18 ` [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue Ming Lei
2014-07-03 9:40 ` Kevin Wolf
2014-07-03 9:51 ` Ming Lei
2014-07-03 10:04 ` Paolo Bonzini
2014-07-03 10:45 ` Ming Lei
2014-07-03 10:50 ` Paolo Bonzini
2014-07-03 11:31 ` Ming Lei
2014-07-03 10:22 ` Kevin Wolf
2014-07-03 10:24 ` Ming Lei
2014-07-03 10:30 ` Kevin Wolf
2014-07-03 12:24 ` Stefan Hajnoczi
2014-07-04 9:18 ` Ming Lei
2014-07-04 9:21 ` Ming Lei
2014-07-02 12:18 ` [Qemu-devel] [PATCH v4 3/3] dataplane: submit I/O as a batch Ming Lei
2014-07-03 9:44 ` Kevin Wolf
2014-07-03 9:49 ` Paolo Bonzini
2014-07-03 10:18 ` Kevin Wolf
2014-07-03 12:35 ` Stefan Hajnoczi
2014-07-03 12:37 ` Stefan Hajnoczi
2014-07-03 12:47 ` Ming Lei
2014-07-03 9:25 ` [Qemu-devel] [PATCH v4 0/3] linux-aio: introduce " Kevin Wolf
2014-07-03 12:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404303528-7115-2-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).