From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
ming.lei@canonical.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] coroutine: dynamically scale pool size
Date: Thu, 3 Jul 2014 15:51:59 +0200 [thread overview]
Message-ID: <1404395521-11158-1-git-send-email-stefanha@redhat.com> (raw)
The coroutine pool reuses exited coroutines to make qemu_coroutine_create()
cheap. The size of the pool is capped to prevent it from hogging memory after
a period of high coroutine activity. Previously the max size was hardcoded to
64 but this doesn't scale with guest size.
A guest with lots of disks can do more parallel I/O and therefore requires a
larger coroutine pool size. This series tries to solve the problem by scaling
pool size according to the number of drives.
Ming: Please let me know if this eliminates the rt_sigprocmask system calls you
are seeing. It should solve part of the performance regression you have seen
in qemu.git/master virtio-blk dataplane.
Stefan Hajnoczi (2):
coroutine: make pool size dynamic
block: bump coroutine pool size for drives
block.c | 4 ++++
include/block/coroutine.h | 11 +++++++++++
qemu-coroutine.c | 25 +++++++++++++++++++------
3 files changed, 34 insertions(+), 6 deletions(-)
--
1.9.3
next reply other threads:[~2014-07-03 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 13:51 Stefan Hajnoczi [this message]
2014-07-03 13:52 ` [Qemu-devel] [PATCH 1/2] coroutine: make pool size dynamic Stefan Hajnoczi
2014-07-03 13:59 ` Eric Blake
2014-07-03 18:29 ` Stefan Hajnoczi
2014-07-03 13:52 ` [Qemu-devel] [PATCH 2/2] block: bump coroutine pool size for drives Stefan Hajnoczi
2014-07-03 14:03 ` Eric Blake
2014-07-04 5:10 ` [Qemu-devel] [PATCH 0/2] coroutine: dynamically scale pool size Ming Lei
2014-07-04 6:31 ` Paolo Bonzini
2014-07-04 7:02 ` Ming Lei
2014-07-04 7:06 ` Paolo Bonzini
2014-07-04 7:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404395521-11158-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).