qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] block: Fix qiov sizes
Date: Fri,  4 Jul 2014 17:55:01 +0200	[thread overview]
Message-ID: <1404489305-8750-1-git-send-email-kwolf@redhat.com> (raw)

Some callers use larger qiovs than nb_sectors for their read requests. This is
bad because raw-posix uses nb_sectors to allocate a bounce buffer and then
copies the whole iov over.

This series fixes some more cases (mirroring was already fixed earlier this
week) and adds assertions to catch any other offenders.

Kevin Wolf (4):
  block: Make qiov match the request size until EOF
  qcow2: Make qiov match request size until backing file EOF
  qed: Make qiov match request size until backing file EOF
  block: Assert qiov length matches request length

 block.c           | 13 ++++++++++++-
 block/qcow2.c     | 11 ++++++++++-
 block/qed.c       | 26 +++++++++++++++++++++++---
 block/qed.h       |  1 +
 block/raw-posix.c | 15 +++++++++++----
 5 files changed, 57 insertions(+), 9 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2014-07-04 15:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 15:55 Kevin Wolf [this message]
2014-07-04 15:55 ` [Qemu-devel] [PATCH 1/4] block: Make qiov match the request size until EOF Kevin Wolf
2014-07-05 19:19   ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 2/4] qcow2: Make qiov match request size until backing file EOF Kevin Wolf
2014-07-05 19:37   ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 3/4] qed: " Kevin Wolf
2014-07-05 20:06   ` Max Reitz
2014-07-08 13:07     ` Kevin Wolf
2014-07-08 13:14     ` [Qemu-devel] [PATCH v2 for-2.1 " Kevin Wolf
2014-07-09  1:52       ` Eric Blake
2014-07-04 15:55 ` [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length Kevin Wolf
2014-07-05 20:14   ` Max Reitz
2014-07-07 15:05 ` [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes Eric Blake
2014-07-09 11:34 ` [Qemu-devel] [PATCH " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404489305-8750-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).