From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3DZF-0001ev-Cq for qemu-devel@nongnu.org; Fri, 04 Jul 2014 20:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3DZA-00059o-EN for qemu-devel@nongnu.org; Fri, 04 Jul 2014 20:11:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3DZA-00059e-5G for qemu-devel@nongnu.org; Fri, 04 Jul 2014 20:10:56 -0400 From: Eduardo Habkost Date: Fri, 4 Jul 2014 21:09:35 -0300 Message-Id: <1404519002-10224-9-git-send-email-ehabkost@redhat.com> In-Reply-To: <1404519002-10224-1-git-send-email-ehabkost@redhat.com> References: <1404519002-10224-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC v3 08/35] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Stefan Weil , "Michael S. Tsirkin" , Alexander Graf , Don Slutz , Gerd Hoffmann , Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= The VGA and vmware-svga rombar compat properties were added by commit 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently follow. The new variables will now be inherited by pc-0.11 and older, but pc-0.11 and pc-0.10 already have PCI.rombar=0 on compat_props, so they shouldn't be affected at all. Signed-off-by: Eduardo Habkost Cc: Stefan Weil Cc: Gerd Hoffmann --- hw/i386/pc_piix.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cf3318d..21c9720 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -716,6 +716,14 @@ static QEMUMachine pc_machine_v0_14 = { .driver = "virtio-9p-pci",\ .property = "vectors",\ .value = stringify(0),\ + },{\ + .driver = "VGA",\ + .property = "rombar",\ + .value = stringify(0),\ + },{\ + .driver = "vmware-svga",\ + .property = "rombar",\ + .value = stringify(0),\ } #define PC_I440FX_0_13_MACHINE_OPTIONS \ @@ -727,15 +735,6 @@ static QEMUMachine pc_machine_v0_13 = { .name = "pc-0.13", .compat_props = (GlobalProperty[]) { PC_COMPAT_0_13, - { - .driver = "VGA", - .property = "rombar", - .value = stringify(0), - },{ - .driver = "vmware-svga", - .property = "rombar", - .value = stringify(0), - }, { /* end of list */ } }, .hw_version = "0.13", @@ -770,15 +769,6 @@ static QEMUMachine pc_machine_v0_12 = { .name = "pc-0.12", .compat_props = (GlobalProperty[]) { PC_COMPAT_0_12, - { - .driver = "VGA", - .property = "rombar", - .value = stringify(0), - },{ - .driver = "vmware-svga", - .property = "rombar", - .value = stringify(0), - }, { /* end of list */ } }, .hw_version = "0.12", -- 1.9.3