From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3fL1-0004qe-KB
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 01:50:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3fKv-0001I7-Fo
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 01:50:11 -0400
Received: from gate.crashing.org ([63.228.1.57]:36150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3fKv-0001Cw-7I
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 01:50:05 -0400
Message-ID: <1404625798.29546.214.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sun, 06 Jul 2014 15:49:58 +1000
In-Reply-To: <1404613171.29546.211.camel@pasglop>
References: <1402974463.7661.102.camel@pasglop>
	<1403001900.1614.10.camel@nilsson.home.kraxel.org>
	<1403003721.7661.148.camel@pasglop>
	<1403006267.1614.14.camel@nilsson.home.kraxel.org>
	<1403040734.7661.173.camel@pasglop>
	<1403090315.13406.3.camel@nilsson.home.kraxel.org>
	<1403096614.7661.208.camel@pasglop>
	<1403170570.22530.5.camel@nilsson.home.kraxel.org>
	<1403329021.4587.78.camel@pasglop> <1403403026.4587.108.camel@pasglop>
	<1404126876.24066.23.camel@nilsson.home.kraxel.org>
	<1404131521.29546.3.camel@pasglop>
	<1404202838.24066.52.camel@nilsson.home.kraxel.org>
	<53B270CD.7080907@suse.de> <53B271EE.4030308@redhat.com>
	<1404205639.24066.58.camel@nilsson.home.kraxel.org>
	<53B27D25.4030603@redhat.com>
	<1404213329.24066.64.camel@nilsson.home.kraxel.org>
	<1404213827.29546.58.camel@pasglop> <1404292780.29546.90.camel@pasglop>
	<1404303120.7258.10.camel@nilsson.home.kraxel.org>
	<1404613171.29546.211.camel@pasglop>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing
	changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Sun, 2014-07-06 at 12:19 +1000, Benjamin Herrenschmidt wrote:

> I've started to look (and while at it added use of the dirty bitmap to
> catch changes to the HW cursor image just because it looked easy).
> 
> One obvious issue: Your patch:
> 
> gtk: update mouse position in mouse_set()
> 
> Completely breaks cursor movement in NT4 (I haven't checked with other
> guests). It works fine without the patch. This is after cherry-picking
> on top of my series on github.
> 
> Now the cursor is still a white rectangle :-) I need to investigate that
> one a bit more.

Ok, I've found the cirrus bug that causes that white rectangle, but also
the broken icons in 8bpp mode.

We're basically tripping that test in cirrus_bitblt_rop_fwd_*

    if (dstpitch < 0 || srcpitch < 0) {
        /* is 0 valid? srcpitch == 0 could be useful */
        return;
    }

Because when called from cirrus_bitblt_cputovideo_next() we
always pass 0 for both pitch (we do one line at a time).

That done, we now get both HW "emulated" and HW "qemu" cursors
working in 8bpp.

The cursor is still absent in 16, probably a minor glitch, I'll
try to figure that out next.

Cheers,
Ben.