From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3hbZ-0003vo-Fm
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 04:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3hbT-0004cW-1v
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 04:15:25 -0400
Received: from gate.crashing.org ([63.228.1.57]:53965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3hbS-0004cS-OU
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 04:15:18 -0400
Message-ID: <1404634512.29546.235.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sun, 06 Jul 2014 18:15:12 +1000
In-Reply-To: <1404631363.29546.232.camel@pasglop>
References: <1402974463.7661.102.camel@pasglop>
	<1403001900.1614.10.camel@nilsson.home.kraxel.org>
	<1403003721.7661.148.camel@pasglop>
	<1403006267.1614.14.camel@nilsson.home.kraxel.org>
	<1403040734.7661.173.camel@pasglop>
	<1403090315.13406.3.camel@nilsson.home.kraxel.org>
	<1403096614.7661.208.camel@pasglop>
	<1403170570.22530.5.camel@nilsson.home.kraxel.org>
	<1403329021.4587.78.camel@pasglop> <1403403026.4587.108.camel@pasglop>
	<1404126876.24066.23.camel@nilsson.home.kraxel.org>
	<1404131521.29546.3.camel@pasglop>
	<1404202838.24066.52.camel@nilsson.home.kraxel.org>
	<53B270CD.7080907@suse.de> <53B271EE.4030308@redhat.com>
	<1404205639.24066.58.camel@nilsson.home.kraxel.org>
	<53B27D25.4030603@redhat.com>
	<1404213329.24066.64.camel@nilsson.home.kraxel.org>
	<1404213827.29546.58.camel@pasglop> <1404292780.29546.90.camel@pasglop>
	<1404303120.7258.10.camel@nilsson.home.kraxel.org>
	<1404613171.29546.211.camel@pasglop>
	<1404625798.29546.214.camel@pasglop>
	<1404629182.29546.224.camel@pasglop>
	<1404630327.29546.225.camel@pasglop>
	<1404631363.29546.232.camel@pasglop>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing
	changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Sun, 2014-07-06 at 17:22 +1000, Benjamin Herrenschmidt wrote:

>  - With SDL, the screen colors are all wrong :-) It looks like a
> component is partially missing. Not sure what's up there, again,
> something else to debug. Everything has a blue tint (this is full emu on
> x86_64 host).

That one is a typo in your "add qemu_pixelformat_from_pixman" that
you appear to have already fixed in your console-wip branch, so I'll
rebase my work on top of that (oh well, debugging it taught me a few
things ...).

One thing that I do worry a bit about is that by extending the cases
for shared pixmaps to 15 and 24bpp, I broke SDL since at least the
sdl2 code seems to only know about 16 (5:6:5) and 32 (8:8:8:8).

I'll probably have to fix these too (or bring back shadow pixmaps
for those formats which would be sad).

Cheers,
Ben.