From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3wUN-00019I-FO
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 20:09:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3wUH-0000rN-A8
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 20:08:59 -0400
Received: from gate.crashing.org ([63.228.1.57]:41384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1X3wUH-0000rI-0q
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 20:08:53 -0400
Message-ID: <1404691722.29546.280.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 07 Jul 2014 10:08:42 +1000
In-Reply-To: <1404680167.29546.277.camel@pasglop>
References: <1402974463.7661.102.camel@pasglop>
	<1403040734.7661.173.camel@pasglop>
	<1403090315.13406.3.camel@nilsson.home.kraxel.org>
	<1403096614.7661.208.camel@pasglop>
	<1403170570.22530.5.camel@nilsson.home.kraxel.org>
	<1403329021.4587.78.camel@pasglop> <1403403026.4587.108.camel@pasglop>
	<1404126876.24066.23.camel@nilsson.home.kraxel.org>
	<1404131521.29546.3.camel@pasglop>
	<1404202838.24066.52.camel@nilsson.home.kraxel.org>
	<53B270CD.7080907@suse.de> <53B271EE.4030308@redhat.com>
	<1404205639.24066.58.camel@nilsson.home.kraxel.org>
	<53B27D25.4030603@redhat.com>
	<1404213329.24066.64.camel@nilsson.home.kraxel.org>
	<1404213827.29546.58.camel@pasglop> <1404292780.29546.90.camel@pasglop>
	<1404303120.7258.10.camel@nilsson.home.kraxel.org>
	<1404613171.29546.211.camel@pasglop>
	<1404625798.29546.214.camel@pasglop>
	<1404629182.29546.224.camel@pasglop>
	<1404630327.29546.225.camel@pasglop>
	<1404631363.29546.232.camel@pasglop>
	<1404641621.29546.253.camel@pasglop> <53B92E16.20604@suse.de>
	<CAFEAcA_U9kQ2OW3jCcNshO+0CJ3M2nV-n__+1ZeX2sjMTuZcWw@mail.gmail.com>
	<1404645831.29546.257.camel@pasglop>
	<CAFEAcA-+3_QY_twKbEA0moXfS2ktiZTz59z0PgDvC8b1m3+ygQ@mail.gmail.com>
	<1404680167.29546.277.camel@pasglop>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing
 changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Gerd Hoffmann <kraxel@redhat.com>

On Mon, 2014-07-07 at 06:56 +1000, Benjamin Herrenschmidt wrote:
> If we do it in the cirrus model itself, then we basically have to
> use the shadow pixmap always (can't ever share) and that means bringing
> back a pile of conversion functions to the VGA model that we were
> getting rid of (not hard ones but still, ie, 15, 16, 24 and 32bpp
> non-swapped to 32bpp) which is somewhat sad.

I've decided to go down that path. The added conversion functions
aren't big, it remains pretty clean and in fact it allows me to
neatly separate the functions between BE and LE framebuffers instead
of "swap" and "non-swap" which avoids one of the macro tricks I had
to do before.

Additionally, we are missing some pixel formats in some of the UIs
for my extended cases of surface sharing so I'll work on that too.

(I wonder if we should add a UI callback to verify if a pixel format
is supports for sharing ... for now I'll just add all the missing
ones to SDL 1 & 2, but somebody will have to look at spice).

Cheers,
Ben.