From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Le Tan <tamlokveer@gmail.com>,
Anthony Liguori <aliguori@amazon.com>,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 06/12] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()
Date: Mon, 7 Jul 2014 15:40:26 +0300 [thread overview]
Message-ID: <1404711994-18228-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1404711994-18228-1-git-send-email-mst@redhat.com>
From: Le Tan <tamlokveer@gmail.com>
In function do_pci_register_device() in file hw/pci/pci.c, move the assignment
of pci_dev->devfn to the position before the call to
pci_device_iommu_address_space(pci_dev) which will use the value of
pci_dev->devfn.
Fixes: 9eda7d373e9c691c070eddcbe3467b991f67f6bd
pci: Introduce helper to retrieve a PCI device's DMA address space
Cc: qemu-stable@nongnu.org
Signed-off-by: Le Tan <tamlokveer@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 17ed510..351d320 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -827,6 +827,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
}
pci_dev->bus = bus;
+ pci_dev->devfn = devfn;
dma_as = pci_device_iommu_address_space(pci_dev);
memory_region_init_alias(&pci_dev->bus_master_enable_region,
@@ -836,7 +837,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
address_space_init(&pci_dev->bus_master_as, &pci_dev->bus_master_enable_region,
name);
- pci_dev->devfn = devfn;
pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
pci_dev->irq_state = 0;
pci_config_alloc(pci_dev);
--
MST
next prev parent reply other threads:[~2014-07-07 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 12:39 [Qemu-devel] [PULL 00/12] pc,vhost,virtio fixes, test Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 01/12] qtest: enable vhost-user-test Michael S. Tsirkin
2014-07-15 17:25 ` Peter Maydell
2014-07-07 12:40 ` [Qemu-devel] [PULL 02/12] numa: check for busy memory backend Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 03/12] pc-dimm: error out if memory hotplug is not enabled Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 04/12] virtio: move common virtio properties to bus class device Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 05/12] Handle G_IO_HUP in tcp_chr_read for tcp chardev Michael S. Tsirkin
2014-07-07 12:40 ` Michael S. Tsirkin [this message]
2014-07-07 12:40 ` [Qemu-devel] [PULL 07/12] acpi: fix typo in memory hotplug MMIO region name Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 08/12] hw/virtio: enable common virtio feature for mmio device Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 09/12] qdev: Don't abort() in case globals can't be set Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 10/12] qdev: Fix crash when using non-device class name on -global Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 11/12] virtio-pci: fix MSI memory region use after free Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 12/12] qemu-char: add chr_add_watch support in mux chardev Michael S. Tsirkin
2014-07-07 18:06 ` [Qemu-devel] [PULL 00/12] pc,vhost,virtio fixes, test Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404711994-18228-7-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).