qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Ming Lei <ming.lei@canonical.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 08/12] hw/virtio: enable common virtio feature for mmio device
Date: Mon, 7 Jul 2014 15:40:32 +0300	[thread overview]
Message-ID: <1404711994-18228-9-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1404711994-18228-1-git-send-email-mst@redhat.com>

From: Ming Lei <ming.lei@canonical.com>

Both 'indirect_desc' and 'event_idx' are bus independent features,
and they should be enabled for mmio devices too.

On arm64 quad core VM(qemu-kvm), the patch can increase block I/O
performance a lot with latest linux tree:
        - without the patch: 14K IOPS
        - with the patch: 34K IOPS

fio script:
        [global]
        direct=1
        bsrange=4k-4k
        timeout=10
        numjobs=4
        ioengine=libaio
        iodepth=64

        filename=/dev/vdc
        group_reporting=1

        [f1]
        rw=randread

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-mmio.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index 8829eb0..18c6e5b 100644
--- a/hw/virtio/virtio-mmio.c
+++ b/hw/virtio/virtio-mmio.c
@@ -369,10 +369,16 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp)
     sysbus_init_mmio(sbd, &proxy->iomem);
 }
 
+static Property virtio_mmio_properties[] = {
+    DEFINE_VIRTIO_COMMON_FEATURES(VirtIOMMIOProxy, host_features),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
 static void virtio_mmio_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
 
+    dc->props = virtio_mmio_properties;
     dc->realize = virtio_mmio_realizefn;
     dc->reset = virtio_mmio_reset;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
-- 
MST

  parent reply	other threads:[~2014-07-07 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 12:39 [Qemu-devel] [PULL 00/12] pc,vhost,virtio fixes, test Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 01/12] qtest: enable vhost-user-test Michael S. Tsirkin
2014-07-15 17:25   ` Peter Maydell
2014-07-07 12:40 ` [Qemu-devel] [PULL 02/12] numa: check for busy memory backend Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 03/12] pc-dimm: error out if memory hotplug is not enabled Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 04/12] virtio: move common virtio properties to bus class device Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 05/12] Handle G_IO_HUP in tcp_chr_read for tcp chardev Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 06/12] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space() Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 07/12] acpi: fix typo in memory hotplug MMIO region name Michael S. Tsirkin
2014-07-07 12:40 ` Michael S. Tsirkin [this message]
2014-07-07 12:40 ` [Qemu-devel] [PULL 09/12] qdev: Don't abort() in case globals can't be set Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 10/12] qdev: Fix crash when using non-device class name on -global Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 11/12] virtio-pci: fix MSI memory region use after free Michael S. Tsirkin
2014-07-07 12:40 ` [Qemu-devel] [PULL 12/12] qemu-char: add chr_add_watch support in mux chardev Michael S. Tsirkin
2014-07-07 18:06 ` [Qemu-devel] [PULL 00/12] pc,vhost,virtio fixes, test Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404711994-18228-9-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=ming.lei@canonical.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).