From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4DV0-0003D8-Eb for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4DUs-0004Fx-7P for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:18:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4DUr-0004FX-VK for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:18:38 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s67IIZQ1023420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jul 2014 14:18:36 -0400 From: John Snow Date: Mon, 7 Jul 2014 14:17:56 -0400 Message-Id: <1404757089-4836-16-git-send-email-jsnow@redhat.com> In-Reply-To: <1404757089-4836-1-git-send-email-jsnow@redhat.com> References: <1404757089-4836-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, John Snow , stefanha@redhat.com, mst@redhat.com From: Paolo Bonzini This will provide a hook for sending the result of the command via the FIS receive area. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index bd3bd34..d900ba0 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -422,6 +422,9 @@ static inline void ide_abort_command(IDEState *s) { s->status = READY_STAT | ERR_STAT; s->error = ABRT_ERR; + if (s->end_transfer_func != ide_transfer_stop) { + ide_transfer_stop(s); + } } /* prepare data transfer and tell what to do after */ @@ -588,9 +591,7 @@ void ide_set_inactive(IDEState *s, bool more) void ide_dma_error(IDEState *s) { - ide_transfer_stop(s); - s->error = ABRT_ERR; - s->status = READY_STAT | ERR_STAT; + ide_abort_command(s); ide_set_inactive(s, false); ide_set_irq(s->bus); } -- 1.9.3