From: Bruce Rogers <brogers@suse.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, Bruce Rogers <brogers@suse.com>,
aliguori@amazon.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise
Date: Mon, 7 Jul 2014 17:05:22 -0600 [thread overview]
Message-ID: <1404774322-5709-1-git-send-email-brogers@suse.com> (raw)
When using a memory size less than the default amount with older pc machine
types, a failure occurs because of the way maxram_size and ram_size get
initialized. Keep maxram_size and ram_size the same, except when maxmem
is specified on the command line.
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 6e084c2..0cb8c10 100644
--- a/vl.c
+++ b/vl.c
@@ -3345,7 +3345,6 @@ int main(int argc, char **argv, char **envp)
RAM_ADDR_FMT ")\n", slots, sz, ram_size);
exit(EXIT_FAILURE);
}
- maxram_size = sz;
ram_slots = slots;
} else if ((!maxmem_str && slots_str) ||
(maxmem_str && !slots_str)) {
@@ -3353,6 +3352,7 @@ int main(int argc, char **argv, char **envp)
"'%s' option\n", slots_str ? "maxmem" : "slots");
exit(EXIT_FAILURE);
}
+ maxram_size = sz;
break;
}
#ifdef CONFIG_TPM
--
1.9.0
next reply other threads:[~2014-07-08 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 23:05 Bruce Rogers [this message]
2014-07-08 13:23 ` [Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise Igor Mammedov
2014-07-08 13:51 ` Bruce Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404774322-5709-1-git-send-email-brogers@suse.com \
--to=brogers@suse.com \
--cc=aliguori@amazon.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).