* [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
@ 2014-07-08 13:29 Igor Mammedov
2014-07-11 18:06 ` Michael S. Tsirkin
2014-07-17 15:46 ` Bruce Rogers
0 siblings, 2 replies; 5+ messages in thread
From: Igor Mammedov @ 2014-07-08 13:29 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, mst, brogers
If machine doesn't support memory hotplug then staring QEMU
with initial memory less than default will make QEMU exit with
following error message:
$QEMU -m 16 -M isapc
qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
Set maxram_size to initial memory value before parsing
'maxmem' option allows to keep maxmem in sync with initial
memory size if no maxmem option was specified.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
CC: Bruce Rogers <brogers@suse.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 6e084c2..6abedcf 100644
--- a/vl.c
+++ b/vl.c
@@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
error_report("ram size too large");
exit(EXIT_FAILURE);
}
+ maxram_size = ram_size;
maxmem_str = qemu_opt_get(opts, "maxmem");
slots_str = qemu_opt_get(opts, "slots");
--
1.8.5.2 (Apple Git-48)
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
2014-07-08 13:29 [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types Igor Mammedov
@ 2014-07-11 18:06 ` Michael S. Tsirkin
2014-07-17 14:32 ` Bruce Rogers
2014-07-17 15:46 ` Bruce Rogers
1 sibling, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2014-07-11 18:06 UTC (permalink / raw)
To: Igor Mammedov; +Cc: peter.maydell, qemu-devel, brogers
On Tue, Jul 08, 2014 at 03:29:46PM +0200, Igor Mammedov wrote:
> If machine doesn't support memory hotplug then staring QEMU
> with initial memory less than default will make QEMU exit with
> following error message:
>
> $QEMU -m 16 -M isapc
> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
>
> Set maxram_size to initial memory value before parsing
> 'maxmem' option allows to keep maxmem in sync with initial
> memory size if no maxmem option was specified.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: Bruce Rogers <brogers@suse.com>
OK this is a regression fix so we need it for 2.1.
Applied, thanks!
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 6e084c2..6abedcf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
> error_report("ram size too large");
> exit(EXIT_FAILURE);
> }
> + maxram_size = ram_size;
>
> maxmem_str = qemu_opt_get(opts, "maxmem");
> slots_str = qemu_opt_get(opts, "slots");
> --
> 1.8.5.2 (Apple Git-48)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
2014-07-11 18:06 ` Michael S. Tsirkin
@ 2014-07-17 14:32 ` Bruce Rogers
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Rogers @ 2014-07-17 14:32 UTC (permalink / raw)
To: Igor Mammedov, Michael S. Tsirkin; +Cc: peter.maydell, qemu-devel
>>> On 7/11/2014 at 12:06 PM, <mst@redhat.com> wrote:
> On Tue, Jul 08, 2014 at 03:29:46PM +0200, Igor Mammedov wrote:
>> If machine doesn't support memory hotplug then staring QEMU
>> with initial memory less than default will make QEMU exit with
>> following error message:
>>
>> $QEMU -m 16 -M isapc
>> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
>>
>> Set maxram_size to initial memory value before parsing
>> 'maxmem' option allows to keep maxmem in sync with initial
>> memory size if no maxmem option was specified.
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> CC: Bruce Rogers <brogers@suse.com>
>
> OK this is a regression fix so we need it for 2.1.
>
> Applied, thanks!
>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 6e084c2..6abedcf 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
>> error_report("ram size too large");
>> exit(EXIT_FAILURE);
>> }
>> + maxram_size = ram_size;
>>
>> maxmem_str = qemu_opt_get(opts, "maxmem");
>> slots_str = qemu_opt_get(opts, "slots");
>> --
>> 1.8.5.2 (Apple Git-48)
Hopefully this hasn't been forgotten. This is a bad regression for
pre v2.1 pc machine types.
Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
2014-07-08 13:29 [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types Igor Mammedov
2014-07-11 18:06 ` Michael S. Tsirkin
@ 2014-07-17 15:46 ` Bruce Rogers
2014-07-18 8:34 ` Peter Maydell
1 sibling, 1 reply; 5+ messages in thread
From: Bruce Rogers @ 2014-07-17 15:46 UTC (permalink / raw)
To: qemu-devel, Igor Mammedov; +Cc: peter.maydell, mst
>>> On 7/8/2014 at 07:29 AM, <imammedo@redhat.com> wrote:
> If machine doesn't support memory hotplug then staring QEMU
> with initial memory less than default will make QEMU exit with
> following error message:
>
> $QEMU -m 16 -M isapc
> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
>
> Set maxram_size to initial memory value before parsing
> 'maxmem' option allows to keep maxmem in sync with initial
> memory size if no maxmem option was specified.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: Bruce Rogers <brogers@suse.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 6e084c2..6abedcf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
> error_report("ram size too large");
> exit(EXIT_FAILURE);
> }
> + maxram_size = ram_size;
>
> maxmem_str = qemu_opt_get(opts, "maxmem");
> slots_str = qemu_opt_get(opts, "slots");
Reviewed-By: Bruce Rogers <brogers@suse.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
2014-07-17 15:46 ` Bruce Rogers
@ 2014-07-18 8:34 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2014-07-18 8:34 UTC (permalink / raw)
To: Bruce Rogers; +Cc: Igor Mammedov, QEMU Developers, Michael S. Tsirkin
On 17 July 2014 16:46, Bruce Rogers <brogers@suse.com> wrote:
> >>> On 7/8/2014 at 07:29 AM, <imammedo@redhat.com> wrote:
>> If machine doesn't support memory hotplug then staring QEMU
>> with initial memory less than default will make QEMU exit with
>> following error message:
>>
>> $QEMU -m 16 -M isapc
>> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
>>
>> Set maxram_size to initial memory value before parsing
>> 'maxmem' option allows to keep maxmem in sync with initial
>> memory size if no maxmem option was specified.
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> CC: Bruce Rogers <brogers@suse.com>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 6e084c2..6abedcf 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
>> error_report("ram size too large");
>> exit(EXIT_FAILURE);
>> }
>> + maxram_size = ram_size;
>>
>> maxmem_str = qemu_opt_get(opts, "maxmem");
>> slots_str = qemu_opt_get(opts, "slots");
>
>
> Reviewed-By: Bruce Rogers <brogers@suse.com>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-18 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 13:29 [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types Igor Mammedov
2014-07-11 18:06 ` Michael S. Tsirkin
2014-07-17 14:32 ` Bruce Rogers
2014-07-17 15:46 ` Bruce Rogers
2014-07-18 8:34 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).