From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Z7G-0005EP-D9 for qemu-devel@nongnu.org; Tue, 08 Jul 2014 13:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4Z6N-000130-UI for qemu-devel@nongnu.org; Tue, 08 Jul 2014 13:23:42 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:34406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Z6N-00012s-RJ for qemu-devel@nongnu.org; Tue, 08 Jul 2014 13:22:47 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Jul 2014 13:22:47 -0400 From: Michael Roth Date: Tue, 8 Jul 2014 12:18:38 -0500 Message-Id: <1404839947-1086-128-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1404839947-1086-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1404839947-1086-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 127/156] block/vvfat: Plug memory leak in check_directory_consistency() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Markus Armbruster On error path. Introduced in commit a046433a. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit 6262bbd363b53a1f19c473345d7cc40254dd5c73) Signed-off-by: Michael Roth --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index 3ddaa0b..e71d71e 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1866,7 +1866,7 @@ static int check_directory_consistency(BDRVVVFATState *s, if (s->used_clusters[cluster_num] & USED_ANY) { fprintf(stderr, "cluster %d used more than once\n", (int)cluster_num); - return 0; + goto fail; } s->used_clusters[cluster_num] = USED_DIRECTORY; -- 1.9.1