From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1X4aYs-0004tq-7p
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 14:56:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1X4aYn-0005ka-EB
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 14:56:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1X4aYn-0005kQ-6S
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 14:56:13 -0400
Message-ID: <1404845752.4256.119.camel@ul30vt.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Tue, 08 Jul 2014 12:55:52 -0600
In-Reply-To: <1404736043-22900-4-git-send-email-eric.auger@linaro.org>
References: <1404736043-22900-1-git-send-email-eric.auger@linaro.org>
	<1404736043-22900-4-git-send-email-eric.auger@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 03/13] hw/vfio/pci: Remove unneeded
	include files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Auger <eric.auger@linaro.org>
Cc: agraf@suse.de, kim.phillips@freescale.com, eric.auger@st.com, peter.maydell@linaro.org, patches@linaro.org, will.deacon@arm.com, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com, Bharat.Bhushan@freescale.com, stuart.yoder@freescale.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org

On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote:
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> ---
>  hw/vfio/pci.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 5c7bfd5..a7df3de 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -18,26 +18,14 @@
>   *  Copyright (C) 2008, IBM, Muli Ben-Yehuda (muli@il.ibm.com)
>   */
>  
> -#include <dirent.h>
>  #include <linux/vfio.h>
>  #include <sys/ioctl.h>
>  #include <sys/mman.h>
> -#include <sys/stat.h>
> -#include <sys/types.h>
> -#include <unistd.h>
> -
> -#include "config.h"
>  #include "exec/address-spaces.h"
> -#include "exec/memory.h"
>  #include "hw/pci/msi.h"
>  #include "hw/pci/msix.h"
> -#include "hw/pci/pci.h"
> -#include "qemu-common.h"
>  #include "qemu/error-report.h"
> -#include "qemu/event_notifier.h"
> -#include "qemu/queue.h"
>  #include "qemu/range.h"
> -#include "sysemu/kvm.h"
>  #include "sysemu/sysemu.h"
>  #include "hw/vfio/vfio.h"

Was this just a remove and see if it still compiles exercise?  I'm not
sure I'm a fan of removing includes that are arbitrarily included via
another include chain.  Thanks,

Alex