From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 08/10] AioContext: introduce aio_prepare
Date: Wed, 9 Jul 2014 11:53:08 +0200 [thread overview]
Message-ID: <1404899590-24973-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1404899590-24973-1-git-send-email-pbonzini@redhat.com>
This will be used to implement socket polling on Windows.
On Windows, select() and g_poll() are completely different;
sockets are polled with select() before calling g_poll,
and the g_poll must be nonblocking if select() says a
socket is ready.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
aio-posix.c | 5 +++++
aio-win32.c | 5 +++++
async.c | 5 +++++
include/block/aio.h | 9 ++++++++-
4 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/aio-posix.c b/aio-posix.c
index 0936b4f..d3ac06e 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -100,6 +100,11 @@ void aio_set_event_notifier(AioContext *ctx,
(IOHandler *)io_read, NULL, notifier);
}
+bool aio_prepare(AioContext *ctx)
+{
+ return false;
+}
+
bool aio_pending(AioContext *ctx)
{
AioHandler *node;
diff --git a/aio-win32.c b/aio-win32.c
index fd52686..4542270 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -76,6 +76,11 @@ void aio_set_event_notifier(AioContext *ctx,
aio_notify(ctx);
}
+bool aio_prepare(AioContext *ctx)
+{
+ return false;
+}
+
bool aio_pending(AioContext *ctx)
{
AioHandler *node;
diff --git a/async.c b/async.c
index a5126ff..bcba052 100644
--- a/async.c
+++ b/async.c
@@ -188,6 +188,11 @@ aio_ctx_prepare(GSource *source, gint *timeout)
/* We assume there is no timeout already supplied */
*timeout = qemu_timeout_ns_to_ms(aio_compute_timeout(ctx));
+
+ if (aio_prepare(ctx)) {
+ *timeout = 0;
+ }
+
return *timeout == 0;
}
diff --git a/include/block/aio.h b/include/block/aio.h
index 45408f7..d129e22 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -205,7 +205,14 @@ void qemu_bh_cancel(QEMUBH *bh);
void qemu_bh_delete(QEMUBH *bh);
/* Return whether there are any pending callbacks from the GSource
- * attached to the AioContext.
+ * attached to the AioContext, before g_poll is invoked.
+ *
+ * This is used internally in the implementation of the GSource.
+ */
+bool aio_prepare(AioContext *ctx);
+
+/* Return whether there are any pending callbacks from the GSource
+ * attached to the AioContext, after g_poll is invoked.
*
* This is used internally in the implementation of the GSource.
*/
--
1.9.3
next prev parent reply other threads:[~2014-07-09 9:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 9:53 [Qemu-devel] [PATCH for-2.2 00/10] AioContext cleanups and Win32 socket support Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 01/10] AioContext: take bottom halves into account when computing aio_poll timeout Paolo Bonzini
2014-08-01 14:34 ` Stefan Hajnoczi
2014-08-01 16:03 ` Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 02/10] aio-win32: Evaluate timers after handles Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 03/10] aio-win32: Factor out duplicate code into aio_dispatch_handlers Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 04/10] AioContext: run bottom halves after polling Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 05/10] AioContext: export and use aio_dispatch Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 06/10] test-aio: test timers on Windows too Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 07/10] aio-win32: add aio_set_dispatching optimization Paolo Bonzini
2014-07-09 9:53 ` Paolo Bonzini [this message]
2014-07-09 9:53 ` [Qemu-devel] [PATCH 09/10] qemu-coroutine-io: fix for Win32 Paolo Bonzini
2014-07-09 9:53 ` [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets Paolo Bonzini
2014-09-12 1:39 ` TeLeMan
2014-09-12 10:05 ` Paolo Bonzini
2014-09-13 2:22 ` TeLeMan
2014-09-13 10:33 ` Paolo Bonzini
2014-09-15 1:18 ` TeLeMan
2014-09-15 15:16 ` Paolo Bonzini
2014-09-12 12:51 ` Stefan Hajnoczi
2014-09-12 12:52 ` Paolo Bonzini
2014-09-12 1:43 ` TeLeMan
2014-08-01 14:52 ` [Qemu-devel] [PATCH for-2.2 00/10] AioContext cleanups and Win32 socket support Stefan Hajnoczi
2014-08-01 15:07 ` Paolo Bonzini
2014-08-28 14:00 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404899590-24973-9-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).