qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: crobinso@redhat.com, Andreas Faerber <afaerber@suse.de>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output
Date: Wed,  9 Jul 2014 14:01:30 +0200	[thread overview]
Message-ID: <1404907292-20442-1-git-send-email-stefanha@redhat.com> (raw)

These two patches fix the -device FOO,help output regression that Cole spotted
in QEMU 2.0-rc0.  The problem is that virtio-blk-pci qdev properties have been
converted to QOM alias properties but -device FOO,help shows only qdev
properties.

We simply need to update -device FOO,help code to use both qdev and QOM
properties.  Note that types change because a 'drive' qdev type is actually a
'str' QOM type.  We're moving more and more to QOM properties where the final
type for this property would be 'link<Drive>' or similar.

Cole: please confirm that this fixes the issue

Stefan Hajnoczi (2):
  qmp: hide "hotplugged" device property from device-list-properties
  qdev-monitor: include QOM properties in -device FOO,help output

 qdev-monitor.c | 40 +++++++++++++++++-----------------------
 qmp.c          |  1 +
 2 files changed, 18 insertions(+), 23 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-07-09 12:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 12:01 Stefan Hajnoczi [this message]
2014-07-09 12:01 ` [Qemu-devel] [PATCH for-2.1 1/2] qmp: hide "hotplugged" device property from device-list-properties Stefan Hajnoczi
2014-07-09 12:47   ` Eric Blake
2014-07-09 12:01 ` [Qemu-devel] [PATCH for-2.1 2/2] qdev-monitor: include QOM properties in -device FOO, help output Stefan Hajnoczi
2014-07-09 12:49   ` Eric Blake
2014-07-09 15:20   ` Cole Robinson
2014-07-29 13:32 ` [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404907292-20442-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).