From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4qy1-0008Bf-2d for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:27:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4qxu-0001GM-UO for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:27:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4qxu-0001GG-Mc for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:27:14 -0400 From: Stefan Hajnoczi Date: Wed, 9 Jul 2014 14:01:30 +0200 Message-Id: <1404907292-20442-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: crobinso@redhat.com, Andreas Faerber , Stefan Hajnoczi , Markus Armbruster These two patches fix the -device FOO,help output regression that Cole spotted in QEMU 2.0-rc0. The problem is that virtio-blk-pci qdev properties have been converted to QOM alias properties but -device FOO,help shows only qdev properties. We simply need to update -device FOO,help code to use both qdev and QOM properties. Note that types change because a 'drive' qdev type is actually a 'str' QOM type. We're moving more and more to QOM properties where the final type for this property would be 'link' or similar. Cole: please confirm that this fixes the issue Stefan Hajnoczi (2): qmp: hide "hotplugged" device property from device-list-properties qdev-monitor: include QOM properties in -device FOO,help output qdev-monitor.c | 40 +++++++++++++++++----------------------- qmp.c | 1 + 2 files changed, 18 insertions(+), 23 deletions(-) -- 1.9.3