From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4saf-0005Ix-8q for qemu-devel@nongnu.org; Wed, 09 Jul 2014 10:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4saT-0000QF-AV for qemu-devel@nongnu.org; Wed, 09 Jul 2014 10:11:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4saT-0000Pg-2e for qemu-devel@nongnu.org; Wed, 09 Jul 2014 10:11:09 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69EB7gU007173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 9 Jul 2014 10:11:07 -0400 From: Markus Armbruster Date: Wed, 9 Jul 2014 16:11:01 +0200 Message-Id: <1404915065-15574-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 2.1 0/4] Suppress error action on r/w beyond end List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, uobergfe@redhat.com, stefanha@redhat.com When a device model's I/O operation fails, we execute the error action. This lets layers above QEMU implement thin provisioning, or attempt to correct errors before they reach the guest. But when the I/O operation fails because its invalid, reporting the error to the guest is the only sensible action. SCSI does that, but virtio-blk and IDE don't. Fix them. No other device model supports error actions. v3: * PATCH 2: Resolve semantic conflict with commit 671ec3f "virtio-blk: Convert VirtIOBlockReq.elem to pointer" [Kevin] v2: * PATCH 2: Commit message spelling fix [Fam] * PATCH 4: New, covering IDE Markus Armbruster (4): virtio-blk: Factor common checks out of virtio_blk_handle_read/write() virtio-blk: Bypass error action and I/O accounting on invalid r/w virtio-blk: Treat read/write beyond end as invalid ide: Treat read/write beyond end as invalid hw/block/virtio-blk.c | 45 +++++++++++++++++++++++++++++---------------- hw/ide/core.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+), 16 deletions(-) -- 1.9.3