From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: James Hogan <james.hogan@imgtec.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 03/10] mips_malta: Remove incorrect KVM T&E references
Date: Wed, 9 Jul 2014 17:59:30 +0200 [thread overview]
Message-ID: <1404921577-1461-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1404921577-1461-1-git-send-email-pbonzini@redhat.com>
From: James Hogan <james.hogan@imgtec.com>
Fix the error message and code comments relating to KVM not supporting
booting from the flash mapping when no kernel is provided. The issue is
a general MIPS KVM issue and isn't specific to the Trap & Emulate
version of MIPS KVM.
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/mips/mips_malta.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index c084199..76cf5f2 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1033,7 +1033,7 @@ void mips_malta_init(MachineState *machine)
fl_idx++;
if (kernel_filename) {
ram_low_size = MIN(ram_size, 256 << 20);
- /* For KVM T&E we reserve 1MB of RAM for running bootloader */
+ /* For KVM we reserve 1MB of RAM for running bootloader */
if (kvm_enabled()) {
ram_low_size -= 0x100000;
bootloader_run_addr = 0x40000000 + ram_low_size;
@@ -1057,10 +1057,10 @@ void mips_malta_init(MachineState *machine)
bootloader_run_addr, kernel_entry);
}
} else {
- /* The flash region isn't executable from a KVM T&E guest */
+ /* The flash region isn't executable from a KVM guest */
if (kvm_enabled()) {
error_report("KVM enabled but no -kernel argument was specified. "
- "Booting from flash is not supported with KVM T&E.");
+ "Booting from flash is not supported with KVM.");
exit(1);
}
/* Load firmware from flash. */
--
1.8.3.1
next prev parent reply other threads:[~2014-07-09 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 15:59 [Qemu-devel] [PULL for-2.1 00/10] KVM changes (+ misc small fixes) for 2.1 Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 01/10] mips/kvm: Init EBase to correct KSEG0 Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 02/10] mips_malta: Change default KVM cpu to 24Kc (no FP) Paolo Bonzini
2014-07-09 15:59 ` Paolo Bonzini [this message]
2014-07-09 15:59 ` [Qemu-devel] [PULL 04/10] mips_malta: Catch kernels linked at wrong address Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 05/10] watchdog: fix deadlock with -watchdog-action pause Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 06/10] Enforce stack protector usage Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 07/10] target-i386: Add "kvmclock-stable-bit" feature bit name Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 08/10] oslib-posix: Fix new compiler error with -Wclobbered Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 09/10] mc146818rtc: register the clock reset notifier on the right clock Paolo Bonzini
2014-07-09 15:59 ` [Qemu-devel] [PULL 10/10] qtest: fix vhost-user-test compilation with old GLib Paolo Bonzini
2014-07-09 16:16 ` [Qemu-devel] [PULL for-2.1 00/10] KVM changes (+ misc small fixes) for 2.1 Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-07-10 16:04 [Qemu-devel] [PULL v3 " Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 03/10] mips_malta: Remove incorrect KVM T&E references Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404921577-1461-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=james.hogan@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).