qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC 19/25] accel: Use target-specific accel class if available
Date: Wed,  9 Jul 2014 19:04:16 -0300	[thread overview]
Message-ID: <1404943462-711-20-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1404943462-711-1-git-send-email-ehabkost@redhat.com>

Target-specific accelerator subclasses are optional. If a given
accelerator type needs to make it mandatory, the base class can be made
abstract.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/core/accel.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/hw/core/accel.c b/hw/core/accel.c
index 78e7dfc..6efe36c 100644
--- a/hw/core/accel.c
+++ b/hw/core/accel.c
@@ -51,11 +51,25 @@ static const TypeInfo accel_type = {
 };
 
 /* Lookup AccelClass from opt_name. Returns NULL if not found */
-static AccelClass *accel_find(const char *opt_name)
+static AccelClass *accel_find(const char *opt_name, const char *target_name)
 {
     char *class_name = g_strdup_printf("%s-accel", opt_name);
-    AccelClass *ac = ACCEL_CLASS(object_class_by_name(class_name));
+    char *target_class_name = g_strdup_printf("%s-%s-accel",
+                                              target_name, opt_name);
+    ObjectClass *oc;
+    AccelClass *ac;
+    oc = object_class_by_name(target_class_name);
+    if (!oc) {
+        oc = object_class_by_name(class_name);
+    }
+    /* Must be a TYPE_ACCEL subclass, and not abstract */
+    oc = object_class_dynamic_cast(oc, TYPE_ACCEL);
+    if (oc && object_class_is_abstract(oc)) {
+        oc = NULL;
+    }
+    ac = ACCEL_CLASS(oc);
     g_free(class_name);
+    g_free(target_class_name);
     return ac;
 }
 
@@ -96,7 +110,7 @@ int init_accelerator(MachineState *ms, const char *target_name)
             p++;
         }
         p = get_opt_name(buf, sizeof(buf), p, ':');
-        acc = accel_find(buf);
+        acc = accel_find(buf, target_name);
         if (!acc) {
             fprintf(stderr, "\"%s\" accelerator does not exist.\n", buf);
             continue;
-- 
1.9.3

  parent reply	other threads:[~2014-07-09 22:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 22:03 [Qemu-devel] [RFC 00/25] QOMify accelerator code Eduardo Habkost
2014-07-09 22:03 ` [Qemu-devel] [RFC 01/25] vl.c: Small coding style fix Eduardo Habkost
2014-07-09 22:03 ` [Qemu-devel] [RFC 02/25] accel: Move accel code to accel.c Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 03/25] accel: Create struct AccelType Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 04/25] accel: Simplify configure_accelerator() using AccelType *acc variable Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 05/25] accel: Move accel name lookup to separate function Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 06/25] accel: Use QOM classes for accel types Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 07/25] accel: Make AccelClass.available() optional Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 08/25] accel: Move KVM accel registration to kvm-all.c Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 09/25] accel: Move Xen registration code to xen-common.c Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 10/25] accel: Move qtest accel registration to qtest.c Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 11/25] accel: Remove tcg_available() function Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 12/25] accel: Move accel init/allowed code to separate function Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 13/25] accel: Rename 'init' method to 'init_machine' Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 14/25] accel: Pass MachineState object to accel init functions Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 15/25] accel: Create accel object when initializing machine Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 16/25] accel: Save AccelState on MachineState when initializing Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 17/25] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 18/25] accel: Get target name as argument when initializing accelerator Eduardo Habkost
2014-07-09 22:04 ` Eduardo Habkost [this message]
2014-07-09 22:04 ` [Qemu-devel] [RFC 20/25] accel: TYPE_X86_ACCEL interface Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 21/25] kvm: x86 KVM accelerator subclass Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 22/25] target-i386: Add AccelState parameter to cpu_x86_create() Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 23/25] target-i386: Move accelerator-specific code outside X86CPU.instance_init Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 24/25] target-i386: Accept "host" as value for CPU vendor Eduardo Habkost
2014-07-09 22:04 ` [Qemu-devel] [RFC 25/25] target-i386: Move KVM CPUID hacking to accelerator cpu_post_init hook Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404943462-711-20-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).