qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: James Hogan <james.hogan@imgtec.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 02/10] mips/kvm: Disable FPU on reset with KVM
Date: Thu, 10 Jul 2014 18:04:05 +0200	[thread overview]
Message-ID: <1405008253-9816-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1405008253-9816-1-git-send-email-pbonzini@redhat.com>

From: James Hogan <james.hogan@imgtec.com>

KVM doesn't yet support the MIPS FPU, or writing to the guest's Config1
register which contains the FPU implemented bit. Clear QEMU's version of
that bit on reset and display a warning that the FPU has been disabled.

The previous incorrect Config1 CP0 register value wasn't being passed to
KVM yet, however we should ensure it is set correctly now to reduce the
risk of breaking migration/loadvm to a future version of QEMU/Linux that
does support it.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target-mips/kvm.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/target-mips/kvm.c b/target-mips/kvm.c
index 844e5bb..97fd51a 100644
--- a/target-mips/kvm.c
+++ b/target-mips/kvm.c
@@ -61,6 +61,13 @@ int kvm_arch_init_vcpu(CPUState *cs)
 
 void kvm_mips_reset_vcpu(MIPSCPU *cpu)
 {
+    CPUMIPSState *env = &cpu->env;
+
+    if (env->CP0_Config1 & (1 << CP0C1_FP)) {
+        fprintf(stderr, "Warning: FPU not supported with KVM, disabling\n");
+        env->CP0_Config1 &= ~(1 << CP0C1_FP);
+    }
+
     DPRINTF("%s\n", __func__);
 }
 
-- 
1.8.3.1

  parent reply	other threads:[~2014-07-10 16:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 16:04 [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1 Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 01/10] mips/kvm: Init EBase to correct KSEG0 Paolo Bonzini
2014-07-10 16:04 ` Paolo Bonzini [this message]
2014-07-10 16:04 ` [Qemu-devel] [PULL 03/10] mips_malta: Remove incorrect KVM T&E references Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 04/10] mips_malta: Catch kernels linked at wrong address Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 05/10] watchdog: fix deadlock with -watchdog-action pause Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 06/10] Enforce stack protector usage Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 07/10] target-i386: Add "kvmclock-stable-bit" feature bit name Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 08/10] oslib-posix: Fix new compiler error with -Wclobbered Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 09/10] mc146818rtc: register the clock reset notifier on the right clock Paolo Bonzini
2014-07-10 16:04 ` [Qemu-devel] [PULL 10/10] qtest: fix vhost-user-test compilation with old GLib Paolo Bonzini
2014-07-11 11:13 ` [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1 Peter Maydell
2014-07-11 11:14   ` Paolo Bonzini
2014-07-11 11:18     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405008253-9816-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=james.hogan@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).