[Qemu-devel] [PULL 0/1] mtp: linux guest detection fix

[Qemu-devel] [PULL 0/1] mtp: linux guest detection fix

[Gerd Hoffmann]

  Hi,

USB patch queue with a single mtp bugfix.

please pull,
  Gerd

The following changes since commit 9e99c5fd7060267a0331d900e73fdb36047bfe0c:

  tests: Fix unterminated string output visitor enum human string (2014-07-10 11:53:14 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-usb-20140711-1

for you to fetch changes up to 13d54125a3482a5837682499d25f6be10aa824be:

  mtp: linux guest detection fix. (2014-07-11 12:31:41 +0200)

----------------------------------------------------------------
mtp: linux guest detection fix

----------------------------------------------------------------
Gerd Hoffmann (1):
      mtp: linux guest detection fix.

 hw/usb/dev-mtp.c | 4 ++++
 1 file changed, 4 insertions(+)

[Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

[Gerd Hoffmann]

Attach a name to the MTP interface (android phones have this too).

With this patch recent linux guests such as fedora 20 happily detect and
use the device.  It shows up in nautilus file manager automatically, and
simple-mtpfs can mount it.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 380b465..1b51a90 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -145,6 +145,7 @@ enum {
     STR_MANUFACTURER = 1,
     STR_PRODUCT,
     STR_SERIALNUMBER,
+    STR_MTP,
     STR_CONFIG_FULL,
     STR_CONFIG_HIGH,
     STR_CONFIG_SUPER,
@@ -154,6 +155,7 @@ static const USBDescStrings desc_strings = {
     [STR_MANUFACTURER] = MTP_MANUFACTURER,
     [STR_PRODUCT]      = MTP_PRODUCT,
     [STR_SERIALNUMBER] = "34617",
+    [STR_MTP]          = "MTP",
     [STR_CONFIG_FULL]  = "Full speed config (usb 1.1)",
     [STR_CONFIG_HIGH]  = "High speed config (usb 2.0)",
     [STR_CONFIG_SUPER] = "Super speed config (usb 3.0)",
@@ -165,6 +167,7 @@ static const USBDescIface desc_iface_full = {
     .bInterfaceClass               = USB_CLASS_STILL_IMAGE,
     .bInterfaceSubClass            = 0x01,
     .bInterfaceProtocol            = 0x01,
+    .iInterface                    = STR_MTP,
     .eps = (USBDescEndpoint[]) {
         {
             .bEndpointAddress      = USB_DIR_IN | EP_DATA_IN,
@@ -206,6 +209,7 @@ static const USBDescIface desc_iface_high = {
     .bInterfaceClass               = USB_CLASS_STILL_IMAGE,
     .bInterfaceSubClass            = 0x01,
     .bInterfaceProtocol            = 0x01,
+    .iInterface                    = STR_MTP,
     .eps = (USBDescEndpoint[]) {
         {
             .bEndpointAddress      = USB_DIR_IN | EP_DATA_IN,
-- 
1.8.3.1

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

[Markus Armbruster]

Gerd Hoffmann <kraxel@redhat.com> writes:

> Attach a name to the MTP interface (android phones have this too).
>
> With this patch recent linux guests such as fedora 20 happily detect and
> use the device.  It shows up in nautilus file manager automatically, and
> simple-mtpfs can mount it.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

This is a pull request.  First time I see this patch on the list.  Sure
you posted it for review before?

Patch looks fine to me, so

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

[Gerd Hoffmann]

On Fr, 2014-07-11 at 13:33 +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> > Attach a name to the MTP interface (android phones have this too).
> >
> > With this patch recent linux guests such as fedora 20 happily detect and
> > use the device.  It shows up in nautilus file manager automatically, and
> > simple-mtpfs can mount it.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> This is a pull request.  First time I see this patch on the list.  Sure
> you posted it for review before?

I think I did, but possibly I don't remember correctly and have sent
this privately only.

cheers,
  Gerd

Re: [Qemu-devel] [PULL 0/1] mtp: linux guest detection fix

[Peter Maydell]

On 11 July 2014 11:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> USB patch queue with a single mtp bugfix.
>
> please pull,
>   Gerd
>
> The following changes since commit 9e99c5fd7060267a0331d900e73fdb36047bfe0c:
>
>   tests: Fix unterminated string output visitor enum human string (2014-07-10 11:53:14 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-usb-20140711-1
>
> for you to fetch changes up to 13d54125a3482a5837682499d25f6be10aa824be:
>
>   mtp: linux guest detection fix. (2014-07-11 12:31:41 +0200)
>
> ----------------------------------------------------------------
> mtp: linux guest detection fix

Applied, thanks.

-- PMM