[Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Liu Yuan]

Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Liu Yuan <namei.unix@gmail.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 7dd43fd..78e7baf 100755
--- a/configure
+++ b/configure
@@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then
     LIBS="$LIBS $libnfs_libs"
   else
     if test "$libnfs" = "yes" ; then
-      feature_not_found "libnfs"
+      feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3"
     fi
     libnfs="no"
   fi
-- 
1.9.1

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Fam Zheng]

On Sat, 07/12 11:17, Liu Yuan wrote:
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 7dd43fd..78e7baf 100755
> --- a/configure
> +++ b/configure
> @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then
>      LIBS="$LIBS $libnfs_libs"
>    else
>      if test "$libnfs" = "yes" ; then
> -      feature_not_found "libnfs"
> +      feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3"

I notice that other occasions of feature_not_found doesn't add "-" between
package and devel.

Fam

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Hu Tao]

On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote:
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 7dd43fd..78e7baf 100755
> --- a/configure
> +++ b/configure
> @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then
>      LIBS="$LIBS $libnfs_libs"
>    else
>      if test "$libnfs" = "yes" ; then
> -      feature_not_found "libnfs"
> +      feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3"
>      fi
>      libnfs="no"
>    fi
> -- 
> 1.9.1
> 

I already had a patch that fixed all similar cases:
http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html.

Regards,
Hu

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote:
> On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote:
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 7dd43fd..78e7baf 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then
> >      LIBS="$LIBS $libnfs_libs"
> >    else
> >      if test "$libnfs" = "yes" ; then
> > -      feature_not_found "libnfs"
> > +      feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3"
> >      fi
> >      libnfs="no"
> >    fi
> > -- 
> > 1.9.1
> > 
> 
> I already had a patch that fixed all similar cases:
> http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html.

Thanks, I have applied Hu's patch to my block-next tree because it
includes this and other cases.

Please CC me on block layer patches.  I co-maintain the block layer with
Kevin and am merging patches this week.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

[Liu Yuan]

On Tue, Jul 15, 2014 at 04:16:14PM +0200, Stefan Hajnoczi wrote:
> On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote:
> > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote:
> > > Cc: Kevin Wolf <kwolf@redhat.com>
> > > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > > ---
> > >  configure | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/configure b/configure
> > > index 7dd43fd..78e7baf 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then
> > >      LIBS="$LIBS $libnfs_libs"
> > >    else
> > >      if test "$libnfs" = "yes" ; then
> > > -      feature_not_found "libnfs"
> > > +      feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3"
> > >      fi
> > >      libnfs="no"
> > >    fi
> > > -- 
> > > 1.9.1
> > > 
> > 
> > I already had a patch that fixed all similar cases:
> > http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html.
> 
> Thanks, I have applied Hu's patch to my block-next tree because it
> includes this and other cases.
> 
> Please CC me on block layer patches.  I co-maintain the block layer with
> Kevin and am merging patches this week.

Umm, I git log see that this file related to block layer mostly sent to kevin,
so I thought I should only send it to Kevin. I'll include you from this time on
as I did before.

Yuan