From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6iVk-0005vq-DO for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6iVa-0002qR-LM for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:49:52 -0400 Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]:62835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6iVa-0002qG-Gj for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:49:42 -0400 Received: by mail-qg0-f47.google.com with SMTP id i50so821531qgf.6 for ; Mon, 14 Jul 2014 08:49:42 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 14 Jul 2014 17:49:24 +0200 Message-Id: <1405352968-3155-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1405352968-3155-1-git-send-email-pbonzini@redhat.com> References: <1405352968-3155-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/5] scsi: Report error when lun number is in use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng From: Fam Zheng In the case that the lun number is taken by another scsi device, don't release the existing device siliently, but report an error to user. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index ea1ac09..4341754 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -177,7 +177,8 @@ static int scsi_qdev_init(DeviceState *qdev) d = scsi_device_find(bus, dev->channel, dev->id, dev->lun); assert(d); if (d->lun == dev->lun && dev != d) { - object_unparent(OBJECT(d)); + error_report("lun already used by '%s'", d->qdev.id); + goto err; } } -- 1.9.3