From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6iVp-00061o-50 for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6iVg-0002sD-0L for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:49:56 -0400 Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:64043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6iVf-0002s3-S7 for qemu-devel@nongnu.org; Mon, 14 Jul 2014 11:49:47 -0400 Received: by mail-qg0-f53.google.com with SMTP id q107so1405725qgd.40 for ; Mon, 14 Jul 2014 08:49:47 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 14 Jul 2014 17:49:27 +0200 Message-Id: <1405352968-3155-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1405352968-3155-1-git-send-email-pbonzini@redhat.com> References: <1405352968-3155-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 4/5] virtio-scsi: fix with -M pc-i440fx-2.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Gilbert Right now starting a machine with virtio-scsi and a <= 2.0 machine type fails with: qemu-system-x86_64: -device virtio-scsi-pci: Property .any_layout not found This is because the any_layout bit was actually never set after virtio-scsi was changed to support arbitrary layout for virtio buffers. (This was just a cleanup and a preparation for virtio 1.0; no guest actually checks the bit, but the new request parsing algorithms are tested even with old guest). Reported-by: David Gilbert Reviewed-by: David Gilbert Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-scsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index 0419ee4..188a2d9 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -178,6 +178,8 @@ typedef struct { DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ + DEFINE_PROP_BIT("any_layout", _state, _feature_field, \ + VIRTIO_F_ANY_LAYOUT, true), \ DEFINE_PROP_BIT("hotplug", _state, _feature_field, VIRTIO_SCSI_F_HOTPLUG, \ true), \ DEFINE_PROP_BIT("param_change", _state, _feature_field, \ -- 1.9.3