Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them

[Gerd Hoffmann <kraxel@redhat.com>]

On Mo, 2014-07-14 at 17:25 +0200, Markus Armbruster wrote:
> Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
> 
> > On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
> >> Paolo Bonzini <pbonzini@redhat.com> writes:
> >>
> >>> Otherwise, hot-unplug of pci-serial-2x trips the assertion
> >>> in memory_region_destroy:
> >>>
> >>>     (qemu) device_del gg
> >>>     (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021:
> >>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first ==
> >>> ((void *)0))' failed.
> >>>     Aborted (core dumped)
> >>>
> >>> Reported-by: Markus Armbruster <armbru@redhat.com>
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>
> >> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> >>
> >
> > Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> 
> Nominating for 2.1, just to be explicit.
> 
> [...]

Hmm, is trivial out of service?  I remember thinking "Ok, trivial patch,
qemu-trivial is cc'ed, that'll pick it up, nothing to do for me."

cheers,
  Gerd

PS: Saw paolo sticked the patch into one of his pull requests meanwhile.