From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X6yDS-00056h-TQ
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 04:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1X6yDN-0002lP-Qp
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 04:36:02 -0400
Message-ID: <1405413340.23139.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 15 Jul 2014 10:35:40 +0200
In-Reply-To: <87fvi46jyc.fsf@blackfin.pond.sub.org>
References: <1403720497-5318-1-git-send-email-pbonzini@redhat.com>
	<877g442kie.fsf@blackfin.pond.sub.org>
	<CAEgOgz77aLSt_vww3LwhT5-kUaJhDnmgdDVVdBfQXQvm-DzSUg@mail.gmail.com>
	<87fvi46jyc.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR
 before destroying them
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On Mo, 2014-07-14 at 17:25 +0200, Markus Armbruster wrote:
> Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
> 
> > On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
> >> Paolo Bonzini <pbonzini@redhat.com> writes:
> >>
> >>> Otherwise, hot-unplug of pci-serial-2x trips the assertion
> >>> in memory_region_destroy:
> >>>
> >>>     (qemu) device_del gg
> >>>     (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021:
> >>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first ==
> >>> ((void *)0))' failed.
> >>>     Aborted (core dumped)
> >>>
> >>> Reported-by: Markus Armbruster <armbru@redhat.com>
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>
> >> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> >>
> >
> > Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> 
> Nominating for 2.1, just to be explicit.
> 
> [...]

Hmm, is trivial out of service?  I remember thinking "Ok, trivial patch,
qemu-trivial is cc'ed, that'll pick it up, nothing to do for me."

cheers,
  Gerd

PS: Saw paolo sticked the patch into one of his pull requests meanwhile.