qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
	brogers@suse.com, pbonzini@redhat.com,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH for-2.1 1/2] module: Simplify module_load()
Date: Tue, 15 Jul 2014 16:04:25 +0200	[thread overview]
Message-ID: <1405433066-4337-2-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1405433066-4337-1-git-send-email-afaerber@suse.de>

The file path is not used for error reporting, so we can free it
directly after use.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 util/module.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/util/module.c b/util/module.c
index 214effb..9fd3030 100644
--- a/util/module.c
+++ b/util/module.c
@@ -202,18 +202,16 @@ static void module_load(module_init_type type)
         for (i = 0; i < ARRAY_SIZE(dirs); i++) {
             fname = g_strdup_printf("%s/%s%s", dirs[i], *mp, HOST_DSOSUF);
             ret = module_load_file(fname);
+            g_free(fname);
+            fname = NULL;
             /* Try loading until loaded a module file */
             if (!ret) {
                 break;
             }
-            g_free(fname);
-            fname = NULL;
         }
         if (ret == -ENOENT) {
             fprintf(stderr, "Can't find module: %s\n", *mp);
         }
-
-        g_free(fname);
     }
 
     for (i = 0; i < ARRAY_SIZE(dirs); i++) {
-- 
1.8.4.5

  reply	other threads:[~2014-07-15 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 14:04 [Qemu-devel] [PATCH for-2.1 0/2] Module cleanups Andreas Färber
2014-07-15 14:04 ` Andreas Färber [this message]
2014-07-15 14:04 ` [Qemu-devel] [PATCH for-2.1 2/2] module: Don't complain when a module is absent Andreas Färber
2014-07-15 15:39 ` [Qemu-devel] [PATCH for-2.1 0/2] Module cleanups Fam Zheng
2014-07-15 15:45   ` Paolo Bonzini
2014-07-15 17:57 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405433066-4337-2-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=brogers@suse.com \
    --cc=famz@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).