From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7jlw-0001Pi-2o for qemu-devel@nongnu.org; Thu, 17 Jul 2014 07:22:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7jll-0003Ng-LY for qemu-devel@nongnu.org; Thu, 17 Jul 2014 07:22:48 -0400 Received: from mail-pd0-x233.google.com ([2607:f8b0:400e:c02::233]:65512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7jll-0003NN-FP for qemu-devel@nongnu.org; Thu, 17 Jul 2014 07:22:37 -0400 Received: by mail-pd0-f179.google.com with SMTP id ft15so2995999pdb.10 for ; Thu, 17 Jul 2014 04:22:36 -0700 (PDT) From: Sanidhya Kashyap Date: Thu, 17 Jul 2014 16:51:17 +0530 Message-Id: <1405596081-29701-5-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> Subject: [Qemu-devel] [PATCH v4 4/8] BitmapLog: hmp interface for dirty bitmap dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah , Sanidhya Kashyap , "Dr. David Alan Gilbert" , Juan Quintela Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 16 ++++++++++++++++ hmp.c | 16 ++++++++++++++++ hmp.h | 1 + 3 files changed, 33 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index d0943b1..575df78 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1788,6 +1788,22 @@ STEXI show available trace events and their state ETEXI + { + .name = "ldb|log-dirty-bitmap", + .args_type = "filename:s,epochs:i?,frequency:i?", + .params = "filename epochs frequency", + .help = "dumps the memory's dirty bitmap to file\n\t\t\t" + "filename: name of the file in which the bitmap will be saved\n\t\t\t" + "epochs: number of times, the memory will be logged\n\t\t\t" + "frequency: time difference in milliseconds between each epoch", + .mhandler.cmd = hmp_log_dirty_bitmap, + }, +STEXI +@item ldb or log-dirty-bitmap @var{filename} +@findex log-dirty-bitmap +dumps the writable working set of a VM's memory to a file +ETEXI + STEXI @end table ETEXI diff --git a/hmp.c b/hmp.c index 4d1838e..3c8e56d 100644 --- a/hmp.c +++ b/hmp.c @@ -1318,6 +1318,22 @@ void hmp_device_del(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &err); } +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict) +{ + const char *filename = qdict_get_str(qdict, "filename"); + int64_t epochs = qdict_get_try_int(qdict, "epochs", 3); + int64_t frequency = qdict_get_try_int(qdict, "frequency", 10); + Error *err = NULL; + + qmp_log_dirty_bitmap(filename, !!epochs, epochs, !!frequency, + frequency, &err); + if (err) { + monitor_printf(mon, "log-dirty-bitmap: %s\n", error_get_pretty(err)); + error_free(err); + return; + } +} + void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict) { Error *err = NULL; diff --git a/hmp.h b/hmp.h index 4fd3c4a..0895182 100644 --- a/hmp.h +++ b/hmp.h @@ -94,6 +94,7 @@ void hmp_cpu_add(Monitor *mon, const QDict *qdict); void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_info_memdev(Monitor *mon, const QDict *qdict); +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict); void object_add_completion(ReadLineState *rs, int nb_args, const char *str); void object_del_completion(ReadLineState *rs, int nb_args, const char *str); void device_add_completion(ReadLineState *rs, int nb_args, const char *str); -- 1.9.3