From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ricky Zhou <ricky@rzhou.org>
Subject: [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled.
Date: Fri, 18 Jul 2014 11:04:20 +0200 [thread overview]
Message-ID: <1405674265-24058-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1405674265-24058-1-git-send-email-pbonzini@redhat.com>
From: Ricky Zhou <ricky@rzhou.org>
Previously, execute would be disabled for all pages with SMEP enabled,
regardless of what mode the access took place in.
Signed-off-by: Ricky Zhou <ricky@rzhou.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 11ca864..47b982b 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -750,7 +750,8 @@ do_check_protect_pse36:
/* the page can be put in the TLB */
prot = PAGE_READ;
if (!(ptep & PG_NX_MASK) &&
- !((env->cr[4] & CR4_SMEP_MASK) && (ptep & PG_USER_MASK))) {
+ (mmu_idx == MMU_USER_IDX ||
+ !((env->cr[4] & CR4_SMEP_MASK) && (ptep & PG_USER_MASK)))) {
prot |= PAGE_EXEC;
}
if (pte & PG_DIRTY_MASK) {
--
1.9.3
next prev parent reply other threads:[~2014-07-18 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:04 [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Paolo Bonzini
2014-07-18 9:04 ` Paolo Bonzini [this message]
2014-07-18 9:04 ` [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700 Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 3/6] module: Simplify module_load() Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent Paolo Bonzini
2014-07-18 13:48 ` Michael Tokarev
2014-07-18 9:04 ` [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation" Paolo Bonzini
2014-07-18 11:31 ` Amit Shah
2014-07-18 11:36 ` Alexander Graf
2014-07-18 11:45 ` Amit Shah
2014-07-18 9:04 ` [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward" Paolo Bonzini
2014-07-18 12:46 ` [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Peter Maydell
2014-07-18 12:55 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-07-18 13:31 [Qemu-devel] [PULL v2 " Paolo Bonzini
2014-07-18 13:31 ` [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405674265-24058-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ricky@rzhou.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).