From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X845w-0007mA-Dz for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:04:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X845q-0004XZ-P0 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:04:48 -0400 Received: from mail-qa0-x233.google.com ([2607:f8b0:400d:c00::233]:58576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X845q-0004XU-K1 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 05:04:42 -0400 Received: by mail-qa0-f51.google.com with SMTP id k15so2737136qaq.38 for ; Fri, 18 Jul 2014 02:04:41 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 18 Jul 2014 11:04:23 +0200 Message-Id: <1405674265-24058-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1405674265-24058-1-git-send-email-pbonzini@redhat.com> References: <1405674265-24058-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Tokarev , =?UTF-8?q?Andreas=20F=C3=A4rber?= From: Andreas Färber The current implementation depends on a configure-time generated list of block modules. When any of them is absent, module_load() emits a warning. This is suboptimal because extracting code to modules was mainly done to allow separate packaging of modules with intrusive dependencies. Absence of optional packages then leads to absence of modules and an error message, which users may recognize as new and report as error. Cc: Paolo Bonzini Cc: Michael Tokarev Reviewed-by: Fam Zheng Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- util/module.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/util/module.c b/util/module.c index 9fd3030..4bd4a94 100644 --- a/util/module.c +++ b/util/module.c @@ -209,9 +209,6 @@ static void module_load(module_init_type type) break; } } - if (ret == -ENOENT) { - fprintf(stderr, "Can't find module: %s\n", *mp); - } } for (i = 0; i < ARRAY_SIZE(dirs); i++) { -- 1.9.3