From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Agi-0002PL-MY for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:07:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8Agb-000532-7M for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:07:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Aga-00051N-Uy for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:07:05 -0400 Message-ID: <1405699595.2696.87.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Fri, 18 Jul 2014 19:06:35 +0300 In-Reply-To: <53C92C02.5020608@suse.de> References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <20140629113701.GA26161@redhat.com> <1405606506.2696.60.camel@localhost.localdomain> <53C7DB9F.1060305@redhat.com> <53C7F06B.4080103@suse.de> <20140717164731.23073.74542@loki> <53C80114.7080302@redhat.com> <53C92C02.5020608@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: Peter Maydell , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Michael Roth , aliguori@amazon.com, Paolo Bonzini On Fri, 2014-07-18 at 16:15 +0200, Andreas F=C3=A4rber wrote: > Am 17.07.2014 19:00, schrieb Paolo Bonzini: > > Il 17/07/2014 18:47, Michael Roth ha scritto: > >>> > My argument for getting this into 2.1 had been to avoid tools > >>> picking up > >>> > these to-be-renamed property names from the start. At this point,= I'm > >>> > not so sure whether it's worse to break management tools or > >>> potentially > >>> > some rarely used/tested option - if we decide for 2.2, is > >>> backporting to > >>> > 2.1.1 an option if we document it in the release notes? > >> IMO, if there's some risk to breaking management or other tools, I'd > >> rather it be left to major releases. And if these values are already > >> misnamed > >> for 2.1.0 and prior, I don't think we stop it from poliferating much > >> more by > >> pushing the fix up by a few months. > >=20 > > I'm not sure in which case management could break (except for qom-get= ). > > Andreas, can you explain? >=20 > I was mainly concerned about qom-set, but same goes for qom-get. The > breakage would be in 2.2, if in 2.1 we introduce properties with foo_ba= r > and rename them to foo-bar in 2.2. Since they're not in 2.0, I had aske= d > Marcel to rename them for 2.1 on a KVM call. >=20 > I checked that sPAPR is not affected, so the only issue is the trivial > g_free(). Since apart from sPAPR we have a compact snippet of propertie= s > being added, grep'ing for occurrences of the old strings and verifying > that the patch changes all properties should be safe for -rc3 if Peter > would be willing to take a pull. Hi, The patch only affects machine properties. The patch will be upstream in a few minutes. Sorry for the delay. Thanks, Marcel >=20 > Andreas >=20