From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8B9D-0002JD-Sd for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8B96-0006VO-D5 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:36:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8B96-0006VD-5n for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:36:32 -0400 Message-ID: <1405701358.2696.96.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Fri, 18 Jul 2014 19:35:58 +0300 In-Reply-To: <53C94C32.7050507@suse.de> References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <53C92E49.7090001@suse.de> <1405699194.2696.84.camel@localhost.localdomain> <53C946F6.4040908@suse.de> <1405700615.2696.93.camel@localhost.localdomain> <53C94C32.7050507@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , mst@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@amazon.com, Andreas =?ISO-8859-1?Q?F=E4rber?= On Fri, 2014-07-18 at 18:32 +0200, Andreas F=C3=A4rber wrote: > Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: > > On Fri, 2014-07-18 at 18:10 +0200, Andreas F=C3=A4rber wrote: > >> Hi, > >> > >> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > >>> On Fri, 2014-07-18 at 16:25 +0200, Andreas F=C3=A4rber wrote: > >>>> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > >>>>> Replaced '_' with '-' to comply with QOM guidelines. > >>>>> Made the conversion from HMP to QMP in vl.c > >>>>> > >>>>> Signed-off-by: Marcel Apfelbaum > >>>>> --- > >>>>> hw/core/machine.c | 8 ++++---- > >>>>> vl.c | 12 +++++++++++- > >>>>> 2 files changed, 15 insertions(+), 5 deletions(-) > >>>> [snip] > >>>>> diff --git a/vl.c b/vl.c > >>>>> index a1686ef..7587c97 100644 > >>>>> --- a/vl.c > >>>>> +++ b/vl.c > >>>>> @@ -2820,15 +2820,25 @@ static int object_set_property(const char= *name, const char *value, void *opaque > >>>>> Object *obj =3D OBJECT(opaque); > >>>>> StringInputVisitor *siv; > >>>>> Error *local_err =3D NULL; > >>>>> + char *c, *qom_name; > >>>>> =20 > >>>>> if (strcmp(name, "qom-type") =3D=3D 0 || strcmp(name, "id") = =3D=3D 0 || > >>>>> strcmp(name, "type") =3D=3D 0) { > >>>>> return 0; > >>>>> } > >>>>> =20 > >>>>> + qom_name =3D g_strdup(name); > >>>>> + c =3D qom_name; > >>>>> + while (*c++) { > >>>>> + if (*c =3D=3D '_') { > >>>>> + *c =3D '-'; > >>>>> + } > >>>>> + } > >>>> > >>>> Actually, is this really safe? By my reading, this function handle= s > >>>> -object as well, which in turn allows - in theory - to instantiate= any > >>>> device, where some will still have underscores in their property n= ames. > >>>> Not sure if all non-device objects such as virtio-rng backends hav= e been > >>>> checked? > >>> Hi Andreas, > >>> > >>> I checked and object_set_property is used only be machine right now= , so > >>> no problem here. > >> > >> Indeed you are right. If -object is no longer using it, can we drop > >> qom-type handling? What changed there? > > Hi Andreas, > >=20 > > The check was originally placed there by Paolo for -object handling. > > We need to find out where the "qom-type" property is coming from. (Wh= at code is adding it) > > If is added automatically at parse/init time we can't get rid of it. > > If is object specific, it is ok. >=20 > It was not a QOM property, it was a QemuOpt parameter for -object and > therefore excluded from the handling like your type property is. Paolo > had dicussed to rename qom-type to type for simplicity and consistency, > but what I don't know is why this function is no longer used. Paolo, can you help? I posted a V2, but I can resend in case it is needed, of course. Thanks, Marcel >=20 > Andreas >=20 > > Paolo, can you please advise? > >=20 > > Thanks, > > Marcel >=20