[Qemu-devel] [PULL for-2.1 0/1] usb: mtp: tag root property as experimental

[Qemu-devel] [PULL for-2.1 0/1] usb: mtp: tag root property as experimental

[Gerd Hoffmann]

  Hi,

Sorry, bad timing on my side.  Patch sent out yesterday, through it
would be a good idea to leave at least one day for review, and now I've
missed -rc3 :(

This patch renames the root property of the usb-mtp device to make clear
this is experimental.  As we eventually move usb-mtp to be backed by
fsdev I don't want commit (yet) to use a filesystem path to specify the
tree to export.

please pull,
  Gerd

The following changes since commit f368c33d5ab09dd5656924185cd975b11838cd25:

  Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-usb-20140723-1

for you to fetch changes up to cf679caf911aa49a25477b3aa20468ee50ed6c89:

  usb: mtp: tag root property as experimental (2014-07-23 08:55:40 +0200)

----------------------------------------------------------------
usb: mtp: tag root property as experimental

----------------------------------------------------------------
Gerd Hoffmann (1):
      usb: mtp: tag root property as experimental

 hw/usb/dev-mtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 1/1] usb: mtp: tag root property as experimental

[Gerd Hoffmann]

Reason: we don't want commit to that interface yet.  Possibly
the implementation will be switched over to use fsdev.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 1b51a90..384d4a5 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1090,7 +1090,7 @@ static const VMStateDescription vmstate_usb_mtp = {
 };
 
 static Property mtp_properties[] = {
-    DEFINE_PROP_STRING("root", MTPState, root),
+    DEFINE_PROP_STRING("x-root", MTPState, root),
     DEFINE_PROP_STRING("desc", MTPState, desc),
     DEFINE_PROP_END_OF_LIST(),
 };
-- 
1.8.3.1

Re: [Qemu-devel] [PULL for-2.1 0/1] usb: mtp: tag root property as experimental

[Peter Maydell]

On 23 July 2014 08:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> Sorry, bad timing on my side.  Patch sent out yesterday, through it
> would be a good idea to leave at least one day for review, and now I've
> missed -rc3 :(
>
> This patch renames the root property of the usb-mtp device to make clear
> this is experimental.  As we eventually move usb-mtp to be backed by
> fsdev I don't want commit (yet) to use a filesystem path to specify the
> tree to export.
>
> please pull,
>   Gerd
>
> The following changes since commit f368c33d5ab09dd5656924185cd975b11838cd25:
>
>   Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-usb-20140723-1
>
> for you to fetch changes up to cf679caf911aa49a25477b3aa20468ee50ed6c89:
>
>   usb: mtp: tag root property as experimental (2014-07-23 08:55:40 +0200)
>
> ----------------------------------------------------------------
> usb: mtp: tag root property as experimental
>
> ----------------------------------------------------------------
> Gerd Hoffmann (1):
>       usb: mtp: tag root property as experimental
>
>  hw/usb/dev-mtp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- PMM