From: John Snow <jsnow@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, philmd@redhat.com,
qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 1/1] python/machine: Change default timeout to 30 seconds
Date: Mon, 20 Jul 2020 16:06:59 -0400 [thread overview]
Message-ID: <14061c9d-be4f-f8ef-049e-c161274a3d84@redhat.com> (raw)
In-Reply-To: <20200720200137.GY1274972@habkost.net>
On 7/20/20 4:01 PM, Eduardo Habkost wrote:
> On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote:
>> 3 seconds is too short for some tests running inside busy VMs. Build it out to
>> a rather generous 30 seconds to find out conclusively if there are more severe
>> problems in the merge/CI tests.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> I would send my Reviewed-by to this patch without blinking if it
> only changed the default value without touching anything else,
> but this changes argument order and defaults in 4 different
> methods.
>
> I will still review this, though, and I will probably reply in a
> few minutes with my Reviewed-by.
sorry, couldn't help myself ...
Since I changed the default, I thought it was better to remove the
default in the inner methods that can't be called by client code anyway.
next prev parent reply other threads:[~2020-07-20 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:02 [PATCH 0/1] python/machine: Change default timeout to 30 seconds John Snow
2020-07-20 16:02 ` [PATCH 1/1] " John Snow
2020-07-20 20:01 ` Eduardo Habkost
2020-07-20 20:06 ` John Snow [this message]
2020-07-20 20:20 ` Eduardo Habkost
2020-07-24 16:31 ` John Snow
2020-07-25 17:46 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14061c9d-be4f-f8ef-049e-c161274a3d84@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).