From: "Marc Marí" <marc.mari.barcelo@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc Marí" <marc.mari.barcelo@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 3/7] libqtest: add QTEST_LOG for debugging qtest testcases
Date: Thu, 24 Jul 2014 20:31:01 +0200 [thread overview]
Message-ID: <1406226665-1710-4-git-send-email-marc.mari.barcelo@gmail.com> (raw)
In-Reply-To: <1406226665-1710-1-git-send-email-marc.mari.barcelo@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
---
tests/libqtest.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 98e8f4b..056275d 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -167,11 +167,12 @@ QTestState *qtest_init(const char *extra_args)
if (s->qemu_pid == 0) {
command = g_strdup_printf("exec %s "
"-qtest unix:%s,nowait "
- "-qtest-log /dev/null "
+ "-qtest-log %s "
"-qmp unix:%s,nowait "
"-machine accel=qtest "
"-display none "
"%s", qemu_binary, socket_path,
+ getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null",
qmp_socket_path,
extra_args ?: "");
execlp("/bin/sh", "sh", "-c", command, NULL);
@@ -397,10 +398,18 @@ QDict *qtest_qmpv(QTestState *s, const char *fmt, va_list ap)
/* No need to send anything for an empty QObject. */
if (qobj) {
+ size_t len;
+ int log = getenv("QTEST_LOG") != NULL;
QString *qstr = qobject_to_json(qobj);
const char *str = qstring_get_str(qstr);
size_t size = qstring_get_length(qstr);
+ if (log) {
+ len = write(2, str, size);
+ if (len != size) {
+ fprintf(stderr, "Could not log\n");
+ }
+ }
/* Send QMP request */
socket_send(s->qmp_fd, str, size);
--
1.7.10.4
next prev parent reply other threads:[~2014-07-24 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 18:30 [Qemu-devel] [PATCH 0/7] Virtio PCI libqos driver Marc Marí
2014-07-24 18:30 ` [Qemu-devel] [PATCH 1/7] tests: Functions bus_foreach and device_find from libqos virtio API Marc Marí
2014-07-25 14:56 ` Stefan Hajnoczi
2014-07-24 18:31 ` [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization Marc Marí
2014-07-25 15:19 ` Stefan Hajnoczi
2014-07-25 17:01 ` Marc Marí
2014-07-28 9:21 ` Stefan Hajnoczi
2014-07-24 18:31 ` Marc Marí [this message]
2014-07-25 15:22 ` [Qemu-devel] [PATCH 3/7] libqtest: add QTEST_LOG for debugging qtest testcases Stefan Hajnoczi
2014-07-24 18:31 ` [Qemu-devel] [PATCH 4/7] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc Marc Marí
2014-07-25 15:22 ` Stefan Hajnoczi
2014-07-29 20:47 ` John Snow
2014-07-29 21:10 ` Peter Maydell
2014-07-24 18:31 ` [Qemu-devel] [PATCH 5/7] libqos: Change free function called in malloc Marc Marí
2014-07-25 15:23 ` Stefan Hajnoczi
2014-07-29 20:47 ` John Snow
2014-07-24 18:31 ` [Qemu-devel] [PATCH 6/7] virtio-blk: Correct bug in support for flexible descriptor layout Marc Marí
2014-07-24 18:31 ` [Qemu-devel] [PATCH 7/7] libqos: Added basic virtqueue support to virtio implementation Marc Marí
2014-07-25 16:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406226665-1710-4-git-send-email-marc.mari.barcelo@gmail.com \
--to=marc.mari.barcelo@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).