From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAwNX-0000SJ-G3 for qemu-devel@nongnu.org; Sat, 26 Jul 2014 03:26:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAwNW-00019H-Hc for qemu-devel@nongnu.org; Sat, 26 Jul 2014 03:26:51 -0400 Received: from qemu.weilnetz.de ([2a03:4000:2:362::1]:37137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAwNW-000198-B9 for qemu-devel@nongnu.org; Sat, 26 Jul 2014 03:26:50 -0400 From: Stefan Weil Date: Sat, 26 Jul 2014 09:26:41 +0200 Message-Id: <1406359601-25583-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH for-2.1] target-arm: Fix bit test in sp_el0_access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Peter Maydell Static code analyzers complain about a dubious & operation used for a boolean value. The code does not test the PSTATE_SP bit as it should. Cc: Peter Maydell Signed-off-by: Stefan Weil --- Hello Peter, I'm not sure whether the "!" is correct at all, because code and comment don't seem to match. But I am not an ARM expert, so please review. Thanks, Stefan target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d343856..6ecaa61 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1853,7 +1853,7 @@ static uint64_t aa64_dczid_read(CPUARMState *env, const ARMCPRegInfo *ri) static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri) { - if (!env->pstate & PSTATE_SP) { + if (!(env->pstate & PSTATE_SP)) { /* Access to SP_EL0 is undefined if it's being used as * the stack pointer. */ -- 1.7.10.4