From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com, dgilbert@redhat.com,
qemu-stable@nongnu.org, amit.shah@redhat.com,
pbonzini@redhat.com, lersek@redhat.com
Subject: [Qemu-devel] [PATCH for-2.1 v2 0/2] Fix migration failure due to ACPI tables size changes
Date: Mon, 28 Jul 2014 08:03:23 +0000 [thread overview]
Message-ID: <1406534605-18911-1-git-send-email-imammedo@redhat.com> (raw)
Changes since v2:
- addressed Laszlo's comments
* fixing typos, rewording comments
* dropping enum-ification of RAMBlock flags
* adding zeroing out destination ramblock
* replacing 'if' with assert()
Changing the ACPI table size causes migration to break, and the memory
hotplug work opened our eyes on how horribly we were breaking things in
2.0 already.
To trigger issue start
QEMU-1.7 with -M pc-i440fx-1.7 -device pci-bridge,chassis_nr=1
and try to migrate to QEMU-2.1 or QEMU-2.0 as result target will fail with:
qemu-system-x86_64: Length mismatch: /rom@etc/acpi/tables: 2000 in != 3000
This fix allows target QEMU to load smaller RAMBlock into a bigger one
and fixes regression which was introduced since 2.0, allowing
forward migration from 1.7/2.0 to 2.1
Fix is also suitable for stable-2.0.
Igor Mammedov (2):
migration: load smaller RAMBlock to a bigger one if permitted
acpi: mark ACPI tables ROM blob as extend-able on migration
arch_init.c | 22 +++++++++++++++++-----
exec.c | 8 ++++++++
hw/core/loader.c | 6 +++++-
hw/i386/acpi-build.c | 2 +-
include/exec/memory.h | 11 +++++++++++
include/exec/ram_addr.h | 3 +++
include/hw/loader.h | 5 +++--
memory.c | 5 +++++
8 files changed, 53 insertions(+), 9 deletions(-)
--
1.8.3.1
next reply other threads:[~2014-07-28 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 8:03 Igor Mammedov [this message]
2014-07-28 8:03 ` [Qemu-devel] [PATCH for-2.1 v2 1/2] migration: load smaller RAMBlock to a bigger one if permitted Igor Mammedov
2014-07-28 8:19 ` Laszlo Ersek
2014-07-28 8:03 ` [Qemu-devel] [PATCH for-2.1 v2 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration Igor Mammedov
2014-07-28 8:44 ` Igor Mammedov
2014-07-28 9:02 ` [Qemu-devel] [PATCH for-2.1 v3 " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406534605-18911-1-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).