From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XBgL0-000514-Jw
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:31:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XBgKu-0005Rv-9N
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:31:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45654)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XBgKu-0005Rf-1z
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:31:12 -0400
Message-ID: <1406536231.20726.1.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 28 Jul 2014 10:30:31 +0200
In-Reply-To: <33183CC9F5247A488A2544077AF1902086C1D228@SZXEMA503-MBS.china.huawei.com>
References: <1406271172-1192-1-git-send-email-arei.gonglei@huawei.com>
	<1406271172-1192-2-git-send-email-arei.gonglei@huawei.com>
	<1406281586.20767.3.camel@nilsson.home.kraxel.org>
	<33183CC9F5247A488A2544077AF1902086C1D228@SZXEMA503-MBS.china.huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add
	modify_boot_device_path function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "Huangweidong (C)" <weidong.huang@huawei.com>, "mst@redhat.com" <mst@redhat.com>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "agraf@suse.de" <agraf@suse.de>, "dmitry@daynix.com" <dmitry@daynix.com>, "akong@redhat.com" <akong@redhat.com>, "armbru@redhat.com" <armbru@redhat.com>, "lersek@redhat.com" <lersek@redhat.com>, "marcel.a@redhat.com" <marcel.a@redhat.com>, "somlo@cmu.edu" <somlo@cmu.edu>, Luonengjun <luonengjun@huawei.com>, "Huangpeng
	(Peter)" <peter.huangpeng@huawei.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "rth@twiddle.net" <rth@twiddle.net>, "kwolf@redhat.com" <kwolf@redhat.com>, "peter.crosthwaite@xilinx.com" <peter.crosthwaite@xilinx.com>, "chenliang (T)" <chenliang88@huawei.com>, "imammedo@redhat.com" <imammedo@redhat.com>, "afaerber@suse.de" <afaerber@suse.de>

  Hi,

> > ... because you can just copy the suffix from the old entry here,
> > instead of expecting the caller pass it in.
> > 
> Okay, agreed.
> 
> But we should also think about the situation which a device don't have
> old entry in global fw_boot_order list.

Throw an error?

I think it is ok to allow only *changing* the bootindex.

cheers,
  Gerd