From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBmxC-0003Ou-OB for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBmx5-0006Xx-6D for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:35:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBmx4-0006WL-W1 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:35:03 -0400 Date: Mon, 28 Jul 2014 17:35:17 +0200 From: "Michael S. Tsirkin" Message-ID: <1406561650-29995-3-git-send-email-mst@redhat.com> References: <1406561650-29995-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406561650-29995-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] loader: mark MR for resizeable blobs as extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , Alexander Graf , Markus Armbruster , Gerd Hoffmann , imammedo@redhat.com, pbonzini@redhat.com, Laszlo Ersek , =?us-ascii?B?PT9VVEYtOD9xP0FuZHJlYXM9MjBGPUMzPUE0cmJlcj89?= This makes migration from older QEMU versions more robust. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index ad6ec67..fc00a87 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -745,6 +745,13 @@ void *rom_add_blob_resizeable(const char *name, const void *blob, if (rom_file_has_mr) { data = rom_set_mr(rom, OBJECT(fw_cfg), devpath); + /* If there's padding at tail, blob is resizeable. + * Set flag to allow migration from older QEMU versions + * where this region could have been smaller. + */ + if (max_len != len) { + memory_region_permit_extendable_migration(rom->mr); + } } else { data = rom->data; } -- MST