From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, jsnow@redhat.com, armbru@redhat.com,
stefanha@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize
Date: Tue, 29 Jul 2014 19:28:56 -0400 [thread overview]
Message-ID: <1406676538-23149-1-git-send-email-jsnow@redhat.com> (raw)
My previous commit, 713e8a10, did not address the fact that
the error checking pathways do not attempt to call
virtio_cleanup and thus can leak memory in hotplug scenarios.
This patchset shuffles around the error checking so it does not
need to perform said cleanup, and changes the error functions
from error_set to error_setg.
John Snow (2):
virtio-rng: Move error-checking forward to prevent memory leak
virtio-rng: replace error_set calls with error_setg
hw/virtio/virtio-rng.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
--
1.9.3
next reply other threads:[~2014-07-29 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 23:28 John Snow [this message]
2014-07-29 23:28 ` [Qemu-devel] [PATCH 1/2] virtio-rng: Move error-checking forward to prevent memory leak John Snow
2014-07-29 23:28 ` [Qemu-devel] [PATCH 2/2] virtio-rng: replace error_set calls with error_setg John Snow
2014-07-30 5:57 ` [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize Markus Armbruster
2014-07-30 15:26 ` Stefan Hajnoczi
2014-08-01 5:09 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406676538-23149-1-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).